ensure scalar width/height when preserving aspect ratio

teunbrand · teunbrand · commit 6da653265539 · 2025-10-21T11:25:45.000+02:00
diff --git a/R/facet-.R b/R/facet-.R
@@ -744,8 +744,8 @@ Facet <- ggproto("Facet", NULL,
       if (identical(unitType(old_width),  "null") &&
           identical(unitType(old_height), "null")) {
         ratio <- as.numeric(old_height) / as.numeric(old_width)
-        new_widths  <- new_widths  %||% (new_heights / ratio)
-        new_heights <- new_heights %||% (new_widths  * ratio)
+        new_widths  <- (new_widths  %||% (new_heights / ratio))[1]
+        new_heights <- (new_heights %||% (new_widths  * ratio))[1]
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -744,8 +744,8 @@ Facet <- ggproto("Facet", NULL,`
`744`	`744`	`if (identical(unitType(old_width), "null") &&`
`745`	`745`	`identical(unitType(old_height), "null")) {`
`746`	`746`	`ratio <- as.numeric(old_height) / as.numeric(old_width)`
`747`		`- new_widths <- new_widths %\|\|% (new_heights / ratio)`
`748`		`- new_heights <- new_heights %\|\|% (new_widths * ratio)`
	`747`	`+ new_widths <- (new_widths %\|\|% (new_heights / ratio))[1]`
	`748`	`+ new_heights <- (new_heights %\|\|% (new_widths * ratio))[1]`
`749`	`749`	`}`
`750`	`750`	`}`
`751`	`751`