Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magrittr::set_names and rlang/purrr::set_names are inconsistent #158

Closed
mmuurr opened this issue Oct 5, 2017 · 3 comments
Closed

magrittr::set_names and rlang/purrr::set_names are inconsistent #158

mmuurr opened this issue Oct 5, 2017 · 3 comments

Comments

@mmuurr
Copy link

mmuurr commented Oct 5, 2017

magrittr::set_names conflicts with rlang/purrr::set_names in an incompatible way.
(The latter version requires only a single argument, using the first arg as the default for the second arg.)

Given the tight integration of magrittr in the tidyverse, should these inconsistencies be snuffed-out?

@smbache
Copy link
Member

smbache commented Oct 5, 2017

Yes. Magrittr aliases should be removed - and will be at some point.

@mmuurr
Copy link
Author

mmuurr commented Oct 5, 2017

Yay, thanks!

(In the meantime, my work-around is what I've dubbed the 'owl idiom', as it returns the same results in both cases: %>% set_names(.,.).)

@hadley
Copy link
Member

hadley commented Jul 2, 2018

Part of #108

@hadley hadley closed this as completed Jul 2, 2018
@ahcyip ahcyip mentioned this issue Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants