Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make agg_vec more efficient #250

Closed
mitchelloharawild opened this issue Aug 8, 2020 · 1 comment
Closed

Make agg_vec more efficient #250

mitchelloharawild opened this issue Aug 8, 2020 · 1 comment

Comments

@mitchelloharawild
Copy link
Member

There is no need for a value if it is aggregated.
field(<agg_vec>, "x") should be the length of disaggregated values, so that dummy values for aggregated positions are not required.

This will require dropping the rcrd type, making it slightly more complicated to implement.
@mitchelloharawild
Copy link
Member Author

Closing in favour of mitchelloharawild/graphvec#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitchelloharawild