Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure gg_season() breaks are not out-of-bounds #162

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Ensure gg_season() breaks are not out-of-bounds #162

merged 1 commit into from
Feb 7, 2024

Conversation

teunbrand
Copy link
Contributor

Hi Mitchell,

For completion, I'll repeat that we've been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break feasts.

This PR updates a break calculation in gg_seasion(). Briefly, when breaks = waiver(), the automatic break calculation can include 0. In the labels function, subsetting using 0 gives an empty vector, which caused a mismatch between length(breaks) and length(labels).

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help feasts get out a fix if necessary.

@teunbrand
Copy link
Contributor Author

This is just a kind reminder that the release is scheduled soon.

@mitchelloharawild mitchelloharawild merged commit 831ee31 into tidyverts:master Feb 7, 2024
@mitchelloharawild
Copy link
Member

mitchelloharawild commented Feb 7, 2024

Thanks! I'll prepare a release as soon as possible.

@teunbrand teunbrand deleted the ggplot2_3.5.0 branch February 7, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants