Skip to content

Commit

Permalink
fixed cran notes
Browse files Browse the repository at this point in the history
  • Loading branch information
earowang committed Jan 24, 2024
1 parent ee53752 commit 88b1e51
Show file tree
Hide file tree
Showing 11 changed files with 37 additions and 25 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ Encoding: UTF-8
Language: en-GB
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.1
RoxygenNote: 7.2.3
16 changes: 8 additions & 8 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,15 @@ S3method(vec_cast,double.yearmonth)
S3method(vec_cast,double.yearquarter)
S3method(vec_cast,double.yearweek)
S3method(vec_cast,tbl_df.tbl_ts)
S3method(vec_cast,tbl_ts)
S3method(vec_cast,tbl_ts.data.frame)
S3method(vec_cast,tbl_ts.tbl_df)
S3method(vec_cast,tbl_ts.tbl_ts)
S3method(vec_cast,yearmonth)
S3method(vec_cast,yearmonth.yearmonth)
S3method(vec_cast,yearquarter)
S3method(vec_cast,yearquarter.yearquarter)
S3method(vec_cast,yearweek)
S3method(vec_cast,yearweek.yearweek)
S3method(vec_proxy,grouped_ts)
S3method(vec_proxy,tbl_ts)
Expand All @@ -176,15 +180,19 @@ S3method(vec_ptype2,POSIXct.yearquarter)
S3method(vec_ptype2,POSIXct.yearweek)
S3method(vec_ptype2,data.frame.tbl_ts)
S3method(vec_ptype2,tbl_df.tbl_ts)
S3method(vec_ptype2,tbl_ts)
S3method(vec_ptype2,tbl_ts.data.frame)
S3method(vec_ptype2,tbl_ts.tbl_df)
S3method(vec_ptype2,tbl_ts.tbl_ts)
S3method(vec_ptype2,yearmonth)
S3method(vec_ptype2,yearmonth.Date)
S3method(vec_ptype2,yearmonth.POSIXct)
S3method(vec_ptype2,yearmonth.yearmonth)
S3method(vec_ptype2,yearquarter)
S3method(vec_ptype2,yearquarter.Date)
S3method(vec_ptype2,yearquarter.POSIXct)
S3method(vec_ptype2,yearquarter.yearquarter)
S3method(vec_ptype2,yearweek)
S3method(vec_ptype2,yearweek.Date)
S3method(vec_ptype2,yearweek.POSIXct)
S3method(vec_ptype2,yearweek.yearweek)
Expand Down Expand Up @@ -313,14 +321,6 @@ export(tsibble)
export(union)
export(unnest_tsibble)
export(update_tsibble)
export(vec_cast.tbl_ts)
export(vec_cast.yearmonth)
export(vec_cast.yearquarter)
export(vec_cast.yearweek)
export(vec_ptype2.tbl_ts)
export(vec_ptype2.yearmonth)
export(vec_ptype2.yearquarter)
export(vec_ptype2.yearweek)
export(yearmonth)
export(yearquarter)
export(yearweek)
Expand Down
2 changes: 2 additions & 0 deletions R/vctrs-tsibble.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
NULL

#' @rdname tsibble-vctrs
#' @method vec_ptype2 tbl_ts
#' @export
vec_ptype2.tbl_ts <- function(x, y, ...) {
UseMethod("vec_ptype2.tbl_ts", y)
Expand Down Expand Up @@ -52,6 +53,7 @@ new_key_data <- function(x) {
}

#' @rdname tsibble-vctrs
#' @method vec_cast tbl_ts
#' @export
vec_cast.tbl_ts <- function(x, to, ...) {
UseMethod("vec_cast.tbl_ts")
Expand Down
4 changes: 3 additions & 1 deletion R/yearmonth.R
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ yearmonth.character <- function(x, format = NULL, ...) {
if (is_null(format)) {
if (any(!grepl("\\D", x))) { # all numbers without delimiter
warn(c(
"`yearmonth()` may yield unexpected results.",
"`yearmonth()` may yield unexpected results.",
i = "Please use arg `format` to supply formats."))
}
}
Expand Down Expand Up @@ -154,6 +154,7 @@ tz.yearmonth <- function(x) {
# }

#' @rdname tsibble-vctrs
#' @method vec_cast yearmonth
#' @export
vec_cast.yearmonth <- function(x, to, ...) {
UseMethod("vec_cast.yearmonth")
Expand Down Expand Up @@ -190,6 +191,7 @@ vec_cast.character.yearmonth <- function(x, to, ...) {
}

#' @rdname tsibble-vctrs
#' @method vec_ptype2 yearmonth
#' @export
vec_ptype2.yearmonth <- function(x, y, ...) {
UseMethod("vec_ptype2.yearmonth", y)
Expand Down
2 changes: 2 additions & 0 deletions R/yearquarter.R
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ tz.yearquarter <- function(x) {
# }

#' @rdname tsibble-vctrs
#' @method vec_cast yearquarter
#' @export
vec_cast.yearquarter <- function(x, to, ...) {
UseMethod("vec_cast.yearquarter")
Expand Down Expand Up @@ -218,6 +219,7 @@ vec_cast.character.yearquarter <- function(x, to, ...) {
}

#' @rdname tsibble-vctrs
#' @method vec_ptype2 yearquarter
#' @export
vec_ptype2.yearquarter <- function(x, y, ...) {
UseMethod("vec_ptype2.yearquarter", y)
Expand Down
2 changes: 2 additions & 0 deletions R/yearweek.R
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ tz.yearweek <- function(x) {
# }

#' @rdname tsibble-vctrs
#' @method vec_cast yearweek
#' @export
vec_cast.yearweek <- function(x, to, ...) {
UseMethod("vec_cast.yearweek")
Expand Down Expand Up @@ -200,6 +201,7 @@ vec_cast.character.yearweek <- function(x, to, ...) {
}

#' @rdname tsibble-vctrs
#' @method vec_ptype2 yearweek
#' @export
vec_ptype2.yearweek <- function(x, y, ...) {
UseMethod("vec_ptype2.yearweek", y)
Expand Down
2 changes: 1 addition & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Test environments

* local mac OS install, R 4.2.0
* local mac OS install, R 4.3.0
* ubuntu 20.04 (on github actions), R-devel, R-release
* mac OS 10.15.4 (on github actions) R-release
* Microsoft Windows Server 2019 10.0.17763 (on github actions) R-release
Expand Down
11 changes: 8 additions & 3 deletions man/difference.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/tsibble-tidyverse.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions man/tsibble-vctrs.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion tsibble.Rproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Version: 1.0
RestoreWorkspace: Default
SaveWorkspace: Default
AlwaysSaveHistory: Default
QuitChildProcessesOnExit: Default

EnableCodeIndexing: Yes
UseSpacesForTab: Yes
Expand Down

0 comments on commit 88b1e51

Please sign in to comment.