Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packagist returning a result with no package key which we don't handle well #93

Closed
mattstauffer opened this issue Jan 22, 2021 · 3 comments
Closed

Packagist returning a result with no package key which we don't handle well #93

mattstauffer opened this issue Jan 22, 2021 · 3 comments
Assignees
@marcusmoore

Comments

@mattstauffer
Copy link
Member

image

My gut is someone deleted the package from Packagist and we're getting an error result from packagist but we're not handling it correctly.
@marcusmoore
Copy link
Contributor

I'll work on this in the near future 👍

@marcusmoore marcusmoore self-assigned this Jan 22, 2021
@marcusmoore
Copy link
Contributor

Having a similar issue when displaying packages
image

In both cases we're not handling the PackagistException and also not checking to make sure those values were returned before using them (obviously). I'll work on both issues soon.

@marcusmoore
Copy link
Contributor

This was handled in eeb5ec9. Further work can be done to mark the package as unavailable/abandoned which is being tracked in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusmoore marcusmoore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattstauffer @marcusmoore