From 7e220519bb21b523373b73e49812c5c1a555ef79 Mon Sep 17 00:00:00 2001 From: Ryan Leung Date: Thu, 8 Aug 2024 16:16:54 +0800 Subject: [PATCH] fix Signed-off-by: Ryan Leung --- .gitignore | 1 + pkg/utils/testutil/leak.go | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index dc2efa5004f..a9d942fe706 100644 --- a/.gitignore +++ b/.gitignore @@ -28,3 +28,4 @@ coverage go.work* embedded_assets_handler.go *.log +*.bin diff --git a/pkg/utils/testutil/leak.go b/pkg/utils/testutil/leak.go index 43d3df150ba..ba2ebb7fcb0 100644 --- a/pkg/utils/testutil/leak.go +++ b/pkg/utils/testutil/leak.go @@ -26,6 +26,7 @@ var LeakOptions = []goleak.Option{ goleak.IgnoreTopFunction("sync.runtime_notifyListWait"), // TODO: remove the below options once we fixed the http connection leak problems goleak.IgnoreTopFunction("internal/poll.runtime_pollWait"), + goleak.IgnoreTopFunction("net/http.(*persistConn).writeLoop"), // natefinch/lumberjack#56, It's a goroutine leak bug. Another ignore option PR https://github.com/pingcap/tidb/pull/27405/ goleak.IgnoreTopFunction("gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"), }