-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Controller Limiter may not work well #8435
Labels
affects-7.1
affects-7.5
affects-8.1
report/customer
Customers have encountered this bug.
severity/major
type/bug
The issue is confirmed as a bug.
Comments
This is caused by:
|
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jul 24, 2024
…#8436) (#8437) close #8435 controller: Fix limiter not functioning well in high concurrency scenarios - In high concurrency scenarios, time may appear rollback because the `now` value passed from outside. high mutext completion leading to more non-sequential execution orders. - Time rollback allows advancing more tokens, which can cause the issue. even result in no limit for the controller. - Fix the problem by avoiding time rollback; instead of acquiring time again within the lock to fix it, as this might incur high costs when frequently acquiring time. Signed-off-by: nolouch <[email protected]> Co-authored-by: nolouch <[email protected]>
This was referenced Jul 25, 2024
3 tasks
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jul 25, 2024
…#8436) (#8439) close #8435 controller: Fix limiter not functioning well in high concurrency scenarios - In high concurrency scenarios, time may appear rollback because the `now` value passed from outside. high mutext completion leading to more non-sequential execution orders. - Time rollback allows advancing more tokens, which can cause the issue. even result in no limit for the controller. - Fix the problem by avoiding time rollback; instead of acquiring time again within the lock to fix it, as this might incur high costs when frequently acquiring time. Signed-off-by: nolouch <[email protected]> Co-authored-by: nolouch <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jul 25, 2024
…#8436) (#8438) close #8435 controller: Fix limiter not functioning well in high concurrency scenarios - In high concurrency scenarios, time may appear rollback because the `now` value passed from outside. high mutext completion leading to more non-sequential execution orders. - Time rollback allows advancing more tokens, which can cause the issue. even result in no limit for the controller. - Fix the problem by avoiding time rollback; instead of acquiring time again within the lock to fix it, as this might incur high costs when frequently acquiring time. Signed-off-by: nolouch <[email protected]> Co-authored-by: nolouch <[email protected]>
This was referenced Jul 25, 2024
/report customer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-7.1
affects-7.5
affects-8.1
report/customer
Customers have encountered this bug.
severity/major
type/bug
The issue is confirmed as a bug.
What did you do?
Run the test added in #8434 . my env 72 cores:
The text was updated successfully, but these errors were encountered: