Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of the gRPC rate limiter #8691

Closed
rleungx opened this issue Oct 11, 2024 · 0 comments · Fixed by #8645
Closed

Improve usability of the gRPC rate limiter #8691

rleungx opened this issue Oct 11, 2024 · 0 comments · Fixed by #8645
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Oct 11, 2024

Enhancement Task

Previously, we introduced #6834 to offer a self-protection mechanism for PD itself. But it only allows using the HTTP API to change the config which is inconvenient. We need to support PD control to manage the configuration.
Besides, after we support the gRPC rate limiter, the error returned will be regarded as the same as the other errors and the client will back off. And pd client doesn't support custom backoff.
We can support configuring custom backoff internally on pd client side to handle different errors so that the caller doesn't need to care about it.

@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Oct 11, 2024
@rleungx rleungx closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant