Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter etcd key compatibility test #9127

Closed
okJiang opened this issue Mar 10, 2025 · 0 comments
Closed

Stricter etcd key compatibility test #9127

okJiang opened this issue Mar 10, 2025 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@okJiang
Copy link
Member

okJiang commented Mar 10, 2025

Enhancement Task

In the previous etcd key refactoring, we modified a significant amount of code related to etcd keys. Due to the code's complexity, it has been challenging to ensure consistency of the keys before and after modifications through manual reviews.

After merging the refactored code, we have already identified two cases of inconsistent modifications:

This indicates that the previous compatibility tests were not able to fully guarantee compatibility. Therefore, I will introduce a stricter compatibility test. It will collect operations on etcd keys from all unit tests, record them, and compare the newly generated operations with the previous ones. If the test fails, it will be necessary to review whether your code has modified the etcd key. If not, you can update the result to pass the test.

@okJiang okJiang added the type/enhancement The issue or PR belongs to an enhancement. label Mar 10, 2025
ti-chi-bot bot added a commit that referenced this issue Mar 18, 2025
ref #9127

Signed-off-by: okJiang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@okJiang okJiang closed this as completed Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant