You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the previous etcd key refactoring, we modified a significant amount of code related to etcd keys. Due to the code's complexity, it has been challenging to ensure consistency of the keys before and after modifications through manual reviews.
After merging the refactored code, we have already identified two cases of inconsistent modifications:
This indicates that the previous compatibility tests were not able to fully guarantee compatibility. Therefore, I will introduce a stricter compatibility test. It will collect operations on etcd keys from all unit tests, record them, and compare the newly generated operations with the previous ones. If the test fails, it will be necessary to review whether your code has modified the etcd key. If not, you can update the result to pass the test.
The text was updated successfully, but these errors were encountered:
Enhancement Task
In the previous etcd key refactoring, we modified a significant amount of code related to etcd keys. Due to the code's complexity, it has been challenging to ensure consistency of the keys before and after modifications through manual reviews.
After merging the refactored code, we have already identified two cases of inconsistent modifications:
GCStateStorage
andGCStateProvider
to storage/endpoints as the new storage layer for GC related metadata #9109 (comment)This indicates that the previous compatibility tests were not able to fully guarantee compatibility. Therefore, I will introduce a stricter compatibility test. It will collect operations on etcd keys from all unit tests, record them, and compare the newly generated operations with the previous ones. If the test fails, it will be necessary to review whether your code has modified the etcd key. If not, you can update the result to pass the test.
The text was updated successfully, but these errors were encountered: