mcs: forward region requests to scheduling server #7023

rleungx · 2023-08-31T09:59:15Z

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR is used to forward region requests to the scheduling server and let it handle the scheduling directly, the operator will be brought through forwarded heartbeat response to API server. Then send it to TiKV.

Check List

Tests

Unit test

Release note

None.

ti-chi-bot · 2023-08-31T09:59:17Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-08-31T09:59:17Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ti-chi-bot · 2023-09-08T08:47:35Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-09-14T07:03:32Z

@rleungx: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rleungx · 2023-09-14T07:03:51Z

/test build

codecov · 2023-09-14T07:27:14Z

Codecov Report

Merging #7023 (d11279a) into master (0888ef6) will increase coverage by 0.06%.
Report is 4 commits behind head on master.
The diff coverage is 59.56%.

@@            Coverage Diff             @@
##           master    #7023      +/-   ##
==========================================
+ Coverage   74.33%   74.40%   +0.06%     
==========================================
  Files         437      440       +3     
  Lines       46855    47150     +295     
==========================================
+ Hits        34831    35080     +249     
- Misses       8947     8985      +38     
- Partials     3077     3085       +8

Flag	Coverage Δ
unittests	`74.40% <59.56%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024

the rest LGTM

lhy1024 · 2023-09-14T07:26:09Z

pkg/core/region.go

@@ -194,6 +195,54 @@ func RegionFromHeartbeat(heartbeat *pdpb.RegionHeartbeatRequest, opts ...RegionC
 	return region
 }

+// RegionFromForward constructs a Region from forwarded region heartbeat.
+func RegionFromForward(heartbeat *schedulingpb.RegionHeartbeatRequest, opts ...RegionCreateOption) *RegionInfo {


RegionFromForward and RegionFromHeartbeat seem to be different only regionKvSize := heartbeat.GetApproximateKvSize() / units.MiB here.

request type is different

lhy1024 · 2023-09-14T07:28:20Z

pkg/mcs/scheduling/server/cluster.go

+}
+
+// processRegionHeartbeat updates the region information.
+func (c *Cluster) processRegionHeartbeat(region *core.RegionInfo) error {


Maybe we can reduce some of the duplicate functions, and of course, we can do it in the next pr.

server/cluster/cluster_test.go

Signed-off-by: Ryan Leung <[email protected]>

rleungx · 2023-09-20T05:57:44Z

/merge

ti-chi-bot · 2023-09-20T05:57:46Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-09-20T05:57:47Z

This pull request has been accepted and is ready to merge.

Commit hash: d11279a

ref tikv#5839 Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot bot requested review from disksing and JmPotato August 31, 2023 09:59

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023

rleungx force-pushed the forward-region branch from 51566c5 to d5016d7 Compare September 14, 2023 06:53

rleungx marked this pull request as ready for review September 14, 2023 06:54

ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Sep 14, 2023

rleungx force-pushed the forward-region branch 2 times, most recently from a46a3e5 to 8adb0d0 Compare September 14, 2023 06:57

rleungx requested review from lhy1024 and removed request for disksing September 14, 2023 06:57

rleungx force-pushed the forward-region branch from 8adb0d0 to 239c75b Compare September 14, 2023 07:02

rleungx removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023

rleungx force-pushed the forward-region branch from 239c75b to 5125b20 Compare September 14, 2023 07:11

lhy1024 reviewed Sep 14, 2023

View reviewed changes

rleungx force-pushed the forward-region branch from ef6995f to 97c330e Compare September 14, 2023 08:02

rleungx mentioned this pull request Sep 15, 2023

Separate scheduling into an independent service #5839

Closed

rleungx force-pushed the forward-region branch from 97c330e to bf547b5 Compare September 18, 2023 07:30

rleungx requested a review from lhy1024 September 18, 2023 07:59

lhy1024 approved these changes Sep 19, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2023

rleungx added 7 commits September 20, 2023 11:50

add http support for scheduling service

3f69ea1

Signed-off-by: Ryan Leung <[email protected]>

unify the microservice http setting

25498b9

Signed-off-by: Ryan Leung <[email protected]>

forward store requests to scheduling server

746e232

Signed-off-by: Ryan Leung <[email protected]>

forward region requests to scheduling server

d124c13

Signed-off-by: Ryan Leung <[email protected]>

update kvproto

09783a9

Signed-off-by: Ryan Leung <[email protected]>

add unit test

b0fe4af

Signed-off-by: Ryan Leung <[email protected]>

address comments

d5dbe36

Signed-off-by: Ryan Leung <[email protected]>

rleungx force-pushed the forward-region branch from bf547b5 to d5dbe36 Compare September 20, 2023 04:03

update kvproto

d11279a

Signed-off-by: Ryan Leung <[email protected]>

JmPotato approved these changes Sep 20, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2023

ti-chi-bot bot merged commit b61a318 into tikv:master Sep 20, 2023
21 of 23 checks passed

rleungx deleted the forward-region branch September 20, 2023 05:59

rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023

mcs: forward region requests to scheduling server (tikv#7023)

643c2c3

ref tikv#5839 Signed-off-by: Ryan Leung <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mcs: forward region requests to scheduling server #7023

mcs: forward region requests to scheduling server #7023

rleungx commented Aug 31, 2023 •

edited

Loading

ti-chi-bot bot commented Aug 31, 2023 •

edited

Loading

ti-chi-bot bot commented Aug 31, 2023

ti-chi-bot bot commented Sep 8, 2023

ti-chi-bot bot commented Sep 14, 2023

/test build

rleungx commented Sep 14, 2023

codecov bot commented Sep 14, 2023 •

edited

Loading

lhy1024 left a comment

lhy1024 Sep 14, 2023

rleungx Sep 14, 2023

lhy1024 Sep 14, 2023

rleungx commented Sep 20, 2023

ti-chi-bot bot commented Sep 20, 2023

ti-chi-bot bot commented Sep 20, 2023

mcs: forward region requests to scheduling server #7023

mcs: forward region requests to scheduling server #7023

Conversation

rleungx commented Aug 31, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Aug 31, 2023 • edited Loading

ti-chi-bot bot commented Aug 31, 2023

ti-chi-bot bot commented Sep 8, 2023

ti-chi-bot bot commented Sep 14, 2023

/test build

rleungx commented Sep 14, 2023

codecov bot commented Sep 14, 2023 • edited Loading

Codecov Report

lhy1024 left a comment

Choose a reason for hiding this comment

lhy1024 Sep 14, 2023

Choose a reason for hiding this comment

rleungx Sep 14, 2023

Choose a reason for hiding this comment

lhy1024 Sep 14, 2023

Choose a reason for hiding this comment

rleungx commented Sep 20, 2023

ti-chi-bot bot commented Sep 20, 2023

ti-chi-bot bot commented Sep 20, 2023

rleungx commented Aug 31, 2023 •

edited

Loading

ti-chi-bot bot commented Aug 31, 2023 •

edited

Loading

codecov bot commented Sep 14, 2023 •

edited

Loading