Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update version to v2023.09.11.1 #7065

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Sep 11, 2023

What problem does this PR solve?

Issue Number: Close #7066

What is changed and how does it work?

Related tidb-dashboard release: pingcap/tidb-dashboard#1588

1. security: improve tidb-dashboard login security, encrypt the login password to avoid transport plain text (required for 6.5 version)
2. debug-api: support pagination for ddl history for debug-api
3. keyvisual: use scanRegions instead of fetch all regions (required for 6.5 version)
4. refine execution plan, now it can be showed as table style

Release note

None.

Test

make pd-server
tiup playground v6.5.4 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2023
@baurine baurine marked this pull request as draft September 11, 2023 07:00
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@baurine
Copy link
Contributor Author

baurine commented Sep 11, 2023

This tidb-dashboard version includes the new feature about refined execution plan, and is promised to bring to 7.4, so this PR needs to cherry-pick to master branch. And it's nice to cherry-pick to the LTS version (7.1, 6.1) as well (so #6997 and #6998 can be closed directly)

@baurine baurine marked this pull request as ready for review September 11, 2023 07:31
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 11, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 11, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 11, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8470c3f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@baurine
Copy link
Contributor Author

baurine commented Sep 12, 2023

/test build

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2023

@baurine: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch
Copy link
Contributor

nolouch commented Sep 12, 2023

/test build

@nolouch
Copy link
Contributor

nolouch commented Sep 12, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit e8f95ac into tikv:release-6.5 Sep 12, 2023
19 checks passed
@baurine baurine deleted the chore/update-dashboard branch September 12, 2023 07:11
@baurine
Copy link
Contributor Author

baurine commented Sep 12, 2023

/cherry-pick master

@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch master: #7079.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 12, 2023
@baurine
Copy link
Contributor Author

baurine commented Sep 12, 2023

/cherry-pick release-7.1

@baurine
Copy link
Contributor Author

baurine commented Sep 12, 2023

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-7.1: #7083.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 12, 2023
@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-6.1: #7084.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 12, 2023
ti-chi-bot bot added a commit that referenced this pull request Sep 12, 2023
close #7066

1. security: improve tidb-dashboard login security, encrypt the login password to avoid transport plain text (required for 6.5 version)
2. debug-api: support pagination for ddl history for debug-api
3. keyvisual: use scanRegions instead of fetch all regions (required for 6.5 version)
4. refine execution plan, now it can be showed as table style

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: Sparkle <[email protected]>
Co-authored-by: nolouch <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Sep 28, 2023
close #7066

1. security: improve tidb-dashboard login security, encrypt the login password to avoid transport plain text (required for 6.5 version)
2. debug-api: support pagination for ddl history for debug-api
3. keyvisual: use scanRegions instead of fetch all regions (required for 6.5 version)
4. refine execution plan, now it can be showed as table style

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024
close #7066

1. security: improve tidb-dashboard login security, encrypt the login password to avoid transport plain text (required for 6.5 version)
2. debug-api: support pagination for ddl history for debug-api
3. keyvisual: use scanRegions instead of fetch all regions (required for 6.5 version)
4. refine execution plan, now it can be showed as table style

Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>

Co-authored-by: husharp <[email protected]>
Co-authored-by: Hu# <[email protected]>
Co-authored-by: husharp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants