mcs/scheduling: register the scheduler handler in API service mode #7082
Conversation
Signed-off-by: JmPotato <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
Signed-off-by: JmPotato <[email protected]>
|
How about also adding a test to validate if pd-ctl can work normally? |
Signed-off-by: JmPotato <[email protected]>
I would like to add it in #7076 after merging this PR to test the scheduler with |
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
bot
added
size/XL
Codecov Report
@@ Coverage Diff @@
## master #7082 +/- ##
==========================================
+ Coverage 74.45% 74.48% +0.03%
==========================================
Files 436 437 +1
Lines 46484 46532 +48
==========================================
+ Hits 34608 34658 +50
+ Misses 8845 8829 -16
- Partials 3031 3045 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -236,19 +236,24 @@ func (h *Handler) AddScheduler(name string, args ...string) error { | |||
| return err | |||
| } | |||
| log.Info("create scheduler", zap.String("scheduler-name", s.GetName()), zap.Strings("scheduler-args", args)) | |||
| if !h.s.IsAPIServiceMode() { | |||
| if h.s.IsAPIServiceMode() { | |||
There was a problem hiding this comment.
Will we not need to forward create-scheduler and remove-scheduler requests to the scheduler server after this pr?
There was a problem hiding this comment.
No, the meta info should all be managed in the API server, and the scheduling service will watch them.
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 72e72b3
|
ti-chi-bot
bot
added
the
status/can-merge
|
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…ikv#7082) ref tikv#5839 To ensure that the HTTP API handler could be initialized properly for each scheduler in the API service mode, this PR updates the scheduler controller and PD server handler to support initialize the HTTP handler only. Signed-off-by: JmPotato <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: ref #5839.
What is changed and how does it work?
Check List
Tests
Release note