-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add region heartbeat duration breakdown metrics #7871
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ecf93b6
*: add region heartbeat duration breakdown metrics
nolouch 509e5d9
Merge remote-tracking branch 'origin/master' into add-lock-metrics
nolouch bd59983
address
nolouch eecb7d7
Merge remote-tracking branch 'origin/master' into add-lock-metrics
nolouch 4d9a680
fix
nolouch 846ddec
Merge branch 'master' into add-lock-metrics
nolouch 37f3a98
address
nolouch 1bf72a3
Merge remote-tracking branch 'nolouch/add-lock-metrics' into add-lock…
nolouch e6d9cd9
Merge branch 'master' into add-lock-metrics
ti-chi-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,256 @@ | ||
// Copyright 2024 TiKV Project Authors. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package core | ||
|
||
import ( | ||
"time" | ||
|
||
"github.com/prometheus/client_golang/prometheus" | ||
"go.uber.org/zap" | ||
) | ||
|
||
var ( | ||
// HeartbeatBreakdownHandleDurationSum is the summary of the processing time of handle the heartbeat stage. | ||
HeartbeatBreakdownHandleDurationSum = prometheus.NewCounterVec( | ||
prometheus.CounterOpts{ | ||
Namespace: "pd", | ||
Subsystem: "core", | ||
Name: "region_heartbeat_breakdown_handle_duration_seconds_sum", | ||
Help: "Bucketed histogram of processing time (s) of handle the heartbeat stage.", | ||
}, []string{"name"}) | ||
|
||
// HeartbeatBreakdownHandleCount is the summary of the processing count of handle the heartbeat stage. | ||
HeartbeatBreakdownHandleCount = prometheus.NewCounterVec( | ||
prometheus.CounterOpts{ | ||
Namespace: "pd", | ||
Subsystem: "core", | ||
Name: "region_heartbeat_breakdown_handle_duration_seconds_count", | ||
Help: "Bucketed histogram of processing count of handle the heartbeat stage.", | ||
}, []string{"name"}) | ||
// AcquireRegionsLockWaitDurationSum is the summary of the processing time of waiting for acquiring regions lock. | ||
AcquireRegionsLockWaitDurationSum = prometheus.NewCounterVec( | ||
prometheus.CounterOpts{ | ||
Namespace: "pd", | ||
Subsystem: "core", | ||
Name: "acquire_regions_lock_wait_duration_seconds_sum", | ||
Help: "Bucketed histogram of processing time (s) of waiting for acquiring regions lock.", | ||
}, []string{"type"}) | ||
// AcquireRegionsLockWaitCount is the summary of the processing count of waiting for acquiring regions lock. | ||
AcquireRegionsLockWaitCount = prometheus.NewCounterVec( | ||
prometheus.CounterOpts{ | ||
Namespace: "pd", | ||
Subsystem: "core", | ||
Name: "acquire_regions_lock_wait_duration_seconds_count", | ||
Help: "Bucketed histogram of processing count of waiting for acquiring regions lock.", | ||
}, []string{"name"}) | ||
|
||
// lock statistics | ||
waitRegionsLockDurationSum = AcquireRegionsLockWaitDurationSum.WithLabelValues("WaitRegionsLock") | ||
waitRegionsLockCount = AcquireRegionsLockWaitCount.WithLabelValues("WaitRegionsLock") | ||
waitSubRegionsLockDurationSum = AcquireRegionsLockWaitDurationSum.WithLabelValues("WaitSubRegionsLock") | ||
waitSubRegionsLockCount = AcquireRegionsLockWaitCount.WithLabelValues("WaitSubRegionsLock") | ||
|
||
// heartbeat breakdown statistics | ||
preCheckDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("PreCheck") | ||
preCheckCount = HeartbeatBreakdownHandleCount.WithLabelValues("PreCheck") | ||
asyncHotStatsDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("AsyncHotStatsDuration") | ||
asyncHotStatsCount = HeartbeatBreakdownHandleCount.WithLabelValues("AsyncHotStatsDuration") | ||
regionGuideDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("RegionGuide") | ||
regionGuideCount = HeartbeatBreakdownHandleCount.WithLabelValues("RegionGuide") | ||
checkOverlapsDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("SaveCache_CheckOverlaps") | ||
checkOverlapsCount = HeartbeatBreakdownHandleCount.WithLabelValues("SaveCache_CheckOverlaps") | ||
validateRegionDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("SaveCache_InvalidRegion") | ||
validateRegionCount = HeartbeatBreakdownHandleCount.WithLabelValues("SaveCache_InvalidRegion") | ||
setRegionDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("SaveCache_SetRegion") | ||
setRegionCount = HeartbeatBreakdownHandleCount.WithLabelValues("SaveCache_SetRegion") | ||
updateSubTreeDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("SaveCache_UpdateSubTree") | ||
updateSubTreeCount = HeartbeatBreakdownHandleCount.WithLabelValues("SaveCache_UpdateSubTree") | ||
regionCollectDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("CollectRegionStats") | ||
regionCollectCount = HeartbeatBreakdownHandleCount.WithLabelValues("CollectRegionStats") | ||
otherDurationSum = HeartbeatBreakdownHandleDurationSum.WithLabelValues("Other") | ||
otherCount = HeartbeatBreakdownHandleCount.WithLabelValues("Other") | ||
) | ||
|
||
func init() { | ||
prometheus.MustRegister(HeartbeatBreakdownHandleDurationSum) | ||
prometheus.MustRegister(HeartbeatBreakdownHandleCount) | ||
prometheus.MustRegister(AcquireRegionsLockWaitDurationSum) | ||
prometheus.MustRegister(AcquireRegionsLockWaitCount) | ||
} | ||
|
||
type saveCacheStats struct { | ||
startTime time.Time | ||
lastCheckTime time.Time | ||
checkOverlapsDuration time.Duration | ||
validateRegionDuration time.Duration | ||
setRegionDuration time.Duration | ||
updateSubTreeDuration time.Duration | ||
} | ||
|
||
// RegionHeartbeatProcessTracer is used to trace the process of handling region heartbeat. | ||
type RegionHeartbeatProcessTracer interface { | ||
Begin() | ||
OnPreCheckFinished() | ||
OnAsyncHotStatsFinished() | ||
OnRegionGuideFinished() | ||
OnSaveCacheBegin() | ||
OnSaveCacheFinished() | ||
OnCheckOverlapsFinished() | ||
OnValidateRegionFinished() | ||
OnSetRegionFinished() | ||
OnUpdateSubTreeFinished() | ||
OnCollectRegionStatsFinished() | ||
OnAllStageFinished() | ||
LogFields() []zap.Field | ||
} | ||
|
||
type noopHeartbeatProcessTracer struct{} | ||
|
||
// NewNoopHeartbeatProcessTracer returns a noop heartbeat process tracer. | ||
func NewNoopHeartbeatProcessTracer() RegionHeartbeatProcessTracer { | ||
return &noopHeartbeatProcessTracer{} | ||
} | ||
|
||
func (n *noopHeartbeatProcessTracer) Begin() {} | ||
func (n *noopHeartbeatProcessTracer) OnPreCheckFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnAsyncHotStatsFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnRegionGuideFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnSaveCacheBegin() {} | ||
func (n *noopHeartbeatProcessTracer) OnSaveCacheFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnCheckOverlapsFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnValidateRegionFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnSetRegionFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnUpdateSubTreeFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnCollectRegionStatsFinished() {} | ||
func (n *noopHeartbeatProcessTracer) OnAllStageFinished() {} | ||
func (n *noopHeartbeatProcessTracer) LogFields() []zap.Field { | ||
return nil | ||
} | ||
|
||
type regionHeartbeatProcessTracer struct { | ||
startTime time.Time | ||
lastCheckTime time.Time | ||
preCheckDuration time.Duration | ||
asyncHotStatsDuration time.Duration | ||
regionGuideDuration time.Duration | ||
saveCacheStats saveCacheStats | ||
OtherDuration time.Duration | ||
} | ||
|
||
// NewHeartbeatProcessTracer returns a heartbeat process tracer. | ||
func NewHeartbeatProcessTracer() RegionHeartbeatProcessTracer { | ||
return ®ionHeartbeatProcessTracer{} | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) Begin() { | ||
now := time.Now() | ||
h.startTime = now | ||
h.lastCheckTime = now | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnPreCheckFinished() { | ||
now := time.Now() | ||
h.preCheckDuration = now.Sub(h.lastCheckTime) | ||
h.lastCheckTime = now | ||
preCheckDurationSum.Add(h.preCheckDuration.Seconds()) | ||
preCheckCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnAsyncHotStatsFinished() { | ||
now := time.Now() | ||
h.asyncHotStatsDuration = now.Sub(h.lastCheckTime) | ||
h.lastCheckTime = now | ||
asyncHotStatsDurationSum.Add(h.preCheckDuration.Seconds()) | ||
asyncHotStatsCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnRegionGuideFinished() { | ||
now := time.Now() | ||
h.regionGuideDuration = now.Sub(h.lastCheckTime) | ||
h.lastCheckTime = now | ||
regionGuideDurationSum.Add(h.regionGuideDuration.Seconds()) | ||
regionGuideCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnSaveCacheBegin() { | ||
now := time.Now() | ||
h.saveCacheStats.startTime = now | ||
h.saveCacheStats.lastCheckTime = now | ||
h.lastCheckTime = now | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnSaveCacheFinished() { | ||
// update the outer checkpoint time | ||
h.lastCheckTime = time.Now() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnCollectRegionStatsFinished() { | ||
now := time.Now() | ||
regionCollectDurationSum.Add(now.Sub(h.lastCheckTime).Seconds()) | ||
regionCollectCount.Inc() | ||
h.lastCheckTime = now | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnCheckOverlapsFinished() { | ||
now := time.Now() | ||
h.saveCacheStats.checkOverlapsDuration = now.Sub(h.lastCheckTime) | ||
h.saveCacheStats.lastCheckTime = now | ||
checkOverlapsDurationSum.Add(h.saveCacheStats.checkOverlapsDuration.Seconds()) | ||
checkOverlapsCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnValidateRegionFinished() { | ||
now := time.Now() | ||
h.saveCacheStats.validateRegionDuration = now.Sub(h.saveCacheStats.lastCheckTime) | ||
h.saveCacheStats.lastCheckTime = now | ||
validateRegionDurationSum.Add(h.saveCacheStats.validateRegionDuration.Seconds()) | ||
validateRegionCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnSetRegionFinished() { | ||
now := time.Now() | ||
h.saveCacheStats.setRegionDuration = now.Sub(h.saveCacheStats.lastCheckTime) | ||
h.saveCacheStats.lastCheckTime = now | ||
setRegionDurationSum.Add(h.saveCacheStats.setRegionDuration.Seconds()) | ||
setRegionCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnUpdateSubTreeFinished() { | ||
now := time.Now() | ||
h.saveCacheStats.updateSubTreeDuration = now.Sub(h.saveCacheStats.lastCheckTime) | ||
h.saveCacheStats.lastCheckTime = now | ||
updateSubTreeDurationSum.Add(h.saveCacheStats.updateSubTreeDuration.Seconds()) | ||
updateSubTreeCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) OnAllStageFinished() { | ||
now := time.Now() | ||
h.OtherDuration = now.Sub(h.lastCheckTime) | ||
otherDurationSum.Add(h.OtherDuration.Seconds()) | ||
otherCount.Inc() | ||
} | ||
|
||
func (h *regionHeartbeatProcessTracer) LogFields() []zap.Field { | ||
return []zap.Field{ | ||
zap.Duration("pre-check-duration", h.preCheckDuration), | ||
zap.Duration("async-hot-stats-duration", h.asyncHotStatsDuration), | ||
zap.Duration("region-guide-duration", h.regionGuideDuration), | ||
zap.Duration("check-overlaps-duration", h.saveCacheStats.checkOverlapsDuration), | ||
zap.Duration("validate-region-duration", h.saveCacheStats.validateRegionDuration), | ||
zap.Duration("set-region-duration", h.saveCacheStats.setRegionDuration), | ||
zap.Duration("update-sub-tree-duration", h.saveCacheStats.updateSubTreeDuration), | ||
zap.Duration("other-duration", h.OtherDuration), | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -824,12 +824,49 @@ func GenerateRegionGuideFunc(enableLog bool) RegionGuideFunc { | |
} | ||
} | ||
|
||
// RWLockStats is a read-write lock with statistics. | ||
type RWLockStats struct { | ||
syncutil.RWMutex | ||
totalWaitTime int64 | ||
lockCount int64 | ||
lastLockCount int64 | ||
lastTotalWaitTime int64 | ||
} | ||
|
||
// Lock locks the lock and records the waiting time. | ||
func (l *RWLockStats) Lock() { | ||
startTime := time.Now() | ||
l.RWMutex.Lock() | ||
elapsed := time.Since(startTime).Nanoseconds() | ||
atomic.AddInt64(&l.totalWaitTime, elapsed) | ||
atomic.AddInt64(&l.lockCount, 1) | ||
} | ||
|
||
// Unlock unlocks the lock. | ||
func (l *RWLockStats) Unlock() { | ||
l.RWMutex.Unlock() | ||
} | ||
|
||
// RLock locks the lock for reading and records the waiting time. | ||
func (l *RWLockStats) RLock() { | ||
startTime := time.Now() | ||
l.RWMutex.RLock() | ||
elapsed := time.Since(startTime).Nanoseconds() | ||
atomic.AddInt64(&l.totalWaitTime, elapsed) | ||
atomic.AddInt64(&l.lockCount, 1) | ||
} | ||
|
||
// RUnlock unlocks the lock for reading. | ||
func (l *RWLockStats) RUnlock() { | ||
l.RWMutex.RUnlock() | ||
} | ||
|
||
// RegionsInfo for export | ||
type RegionsInfo struct { | ||
t syncutil.RWMutex | ||
t RWLockStats | ||
tree *regionTree | ||
regions map[uint64]*regionItem // regionID -> regionInfo | ||
st syncutil.RWMutex | ||
st RWLockStats | ||
subRegions map[uint64]*regionItem // regionID -> regionInfo | ||
leaders map[uint64]*regionTree // storeID -> sub regionTree | ||
followers map[uint64]*regionTree // storeID -> sub regionTree | ||
|
@@ -896,33 +933,38 @@ func (r *RegionsInfo) PutRegion(region *RegionInfo) []*RegionInfo { | |
} | ||
|
||
// PreCheckPutRegion checks if the region is valid to put. | ||
func (r *RegionsInfo) PreCheckPutRegion(region *RegionInfo) (*RegionInfo, []*regionItem, error) { | ||
origin, overlaps := r.GetRelevantRegions(region) | ||
func (r *RegionsInfo) PreCheckPutRegion(region *RegionInfo, trace RegionHeartbeatProcessTracer) (*RegionInfo, []*regionItem, error) { | ||
origin, overlaps := r.GetRelevantRegions(region, trace) | ||
err := check(region, origin, overlaps) | ||
return origin, overlaps, err | ||
} | ||
|
||
// AtomicCheckAndPutRegion checks if the region is valid to put, if valid then put. | ||
func (r *RegionsInfo) AtomicCheckAndPutRegion(region *RegionInfo) ([]*RegionInfo, error) { | ||
func (r *RegionsInfo) AtomicCheckAndPutRegion(region *RegionInfo, trace RegionHeartbeatProcessTracer) ([]*RegionInfo, error) { | ||
r.t.Lock() | ||
var ols []*regionItem | ||
origin := r.getRegionLocked(region.GetID()) | ||
if origin == nil || !bytes.Equal(origin.GetStartKey(), region.GetStartKey()) || !bytes.Equal(origin.GetEndKey(), region.GetEndKey()) { | ||
ols = r.tree.overlaps(®ionItem{RegionInfo: region}) | ||
} | ||
trace.OnCheckOverlapsFinished() | ||
err := check(region, origin, ols) | ||
if err != nil { | ||
r.t.Unlock() | ||
trace.OnValidateRegionFinished() | ||
return nil, err | ||
} | ||
trace.OnValidateRegionFinished() | ||
origin, overlaps, rangeChanged := r.setRegionLocked(region, true, ols...) | ||
r.t.Unlock() | ||
trace.OnSetRegionFinished() | ||
r.UpdateSubTree(region, origin, overlaps, rangeChanged) | ||
trace.OnUpdateSubTreeFinished() | ||
return overlaps, nil | ||
} | ||
|
||
// GetRelevantRegions returns the relevant regions for a given region. | ||
func (r *RegionsInfo) GetRelevantRegions(region *RegionInfo) (origin *RegionInfo, overlaps []*regionItem) { | ||
func (r *RegionsInfo) GetRelevantRegions(region *RegionInfo, trace RegionHeartbeatProcessTracer) (origin *RegionInfo, overlaps []*regionItem) { | ||
r.t.RLock() | ||
defer r.t.RUnlock() | ||
origin = r.getRegionLocked(region.GetID()) | ||
|
@@ -1653,6 +1695,42 @@ func (r *RegionsInfo) GetRegionSizeByRange(startKey, endKey []byte) int64 { | |
return size | ||
} | ||
|
||
// metrics default poll interval | ||
const magicCount = 15 * time.Second | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about just DefaultPollInterval? |
||
|
||
// CollectWaitLockMetrics collects the metrics of waiting time for lock | ||
func (r *RegionsInfo) CollectWaitLockMetrics() { | ||
regionsLockTotalWaitTime := atomic.LoadInt64(&r.t.totalWaitTime) | ||
regionsLockCount := atomic.LoadInt64(&r.t.lockCount) | ||
|
||
lastRegionsLockTotalWaitTime := atomic.LoadInt64(&r.t.lastTotalWaitTime) | ||
lastsRegionsLockCount := atomic.LoadInt64(&r.t.lastLockCount) | ||
|
||
subRegionsLockTotalWaitTime := atomic.LoadInt64(&r.st.totalWaitTime) | ||
subRegionsLockCount := atomic.LoadInt64(&r.st.lockCount) | ||
|
||
lastSubRegionsLockTotalWaitTime := atomic.LoadInt64(&r.st.lastTotalWaitTime) | ||
lastSubRegionsLockCount := atomic.LoadInt64(&r.st.lastLockCount) | ||
|
||
// update last metrics | ||
atomic.StoreInt64(&r.t.lastTotalWaitTime, regionsLockTotalWaitTime) | ||
atomic.StoreInt64(&r.t.lastLockCount, regionsLockCount) | ||
atomic.StoreInt64(&r.st.lastTotalWaitTime, subRegionsLockTotalWaitTime) | ||
atomic.StoreInt64(&r.st.lastLockCount, subRegionsLockCount) | ||
|
||
// skip invalid situation like initial status | ||
if lastRegionsLockTotalWaitTime == 0 || lastsRegionsLockCount == 0 || lastSubRegionsLockTotalWaitTime == 0 || lastSubRegionsLockCount == 0 || | ||
regionsLockTotalWaitTime-lastRegionsLockTotalWaitTime < 0 || regionsLockTotalWaitTime-lastRegionsLockTotalWaitTime > int64(magicCount) || | ||
subRegionsLockTotalWaitTime-lastSubRegionsLockTotalWaitTime < 0 || subRegionsLockTotalWaitTime-lastSubRegionsLockTotalWaitTime > int64(magicCount) { | ||
return | ||
} | ||
|
||
waitRegionsLockDurationSum.Add(time.Duration(regionsLockTotalWaitTime - lastRegionsLockTotalWaitTime).Seconds()) | ||
waitRegionsLockCount.Add(float64(regionsLockCount - lastsRegionsLockCount)) | ||
waitSubRegionsLockDurationSum.Add(time.Duration(subRegionsLockTotalWaitTime - lastSubRegionsLockTotalWaitTime).Seconds()) | ||
waitSubRegionsLockCount.Add(float64(subRegionsLockCount - lastSubRegionsLockCount)) | ||
} | ||
|
||
// GetAdjacentRegions returns region's info that is adjacent with specific region | ||
func (r *RegionsInfo) GetAdjacentRegions(region *RegionInfo) (*RegionInfo, *RegionInfo) { | ||
r.t.RLock() | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to flush these metrics asynchronously? It appears that setting the metrics in the middle of processing may affect the performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok because all of them use atomic. and we can dynamically disable the trace by the config
enable-heartbeat-breakdown-metrics