Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: make compatible with cluster info page display #7929

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 18, 2024

What problem does this PR solve?

Issue Number: Close #7928

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Mar 18, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx March 18, 2024 07:47
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 18, 2024

Before
image
After
image

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2024
@HuSharp
Copy link
Member

HuSharp commented Mar 18, 2024

/build

@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 18, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 6d95602

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 18, 2024

/test rebuild

Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024

@lhy1024: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test rebuild

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 18, 2024

/test build

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #7929 (6d95602) into master (da3b6e3) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7929      +/-   ##
==========================================
- Coverage   73.54%   73.47%   -0.07%     
==========================================
  Files         436      436              
  Lines       48349    48349              
==========================================
- Hits        35558    35525      -33     
- Misses       9731     9756      +25     
- Partials     3060     3068       +8     
Flag Coverage Δ
unittests 73.47% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 1331148 into tikv:master Mar 18, 2024
24 of 27 checks passed
@lhy1024 lhy1024 added the needs-cherry-pick-release-8.0 The PR needs to cherry pick to release-8.0 branch. label Mar 19, 2024
@lhy1024 lhy1024 deleted the dashboard-show branch March 19, 2024 03:28
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #7938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-8.0 The PR needs to cherry pick to release-8.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard cluster info page raise not support micro service error
5 participants