Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: dynamic progress time window for offline scene (#7722) #8007

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7722

What problem does this PR solve?

Issue Number: Close #7726

What is changed and how does it work?

  1. time window length can be changed
  2. Two Pointers algorithm is used to maintain statistics in the time window to avoid data loss when patrol cost time changes

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

tiup playground nightly --tiflash 2 --pd.binpath=/Users/jiangyongbo/github/pd/bin/pd-server
sysbench --mysql-host=127.0.0.1 --mysql-user=root --mysql-port=4000 --mysql-db=sbtest --percentile=99 --report-interval=1 --tables=32 --table_size=500000 oltp_read_only --range_selects --threads=4 --time=9800 prepare
alter table sbtest.sbtset1 set tiflash replica 1;
alter table sbtest.sbtset9 set tiflash replica 1;
alter table sbtest.sbtset17 set tiflash replica 1;
alter table sbtest.sbtset25 set tiflash replica 1;
config set patrol-region-interval 22s
image
image
image
image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 April 1, 2024 02:35
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2024
Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.74%. Comparing base (6ea3d29) to head (f443732).
Report is 2 commits behind head on release-7.1.

❗ Current head f443732 differs from pull request most recent head 2d1db0c. Consider uploading reports for the commit 2d1db0c to get more accurate results

Files Patch % Lines
server/cluster/cluster.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #8007      +/-   ##
===============================================
- Coverage        74.80%   74.74%   -0.07%     
===============================================
  Files              412      412              
  Lines            41750    41779      +29     
===============================================
- Hits             31230    31226       -4     
- Misses            7773     7803      +30     
- Partials          2747     2750       +3     
Flag Coverage Δ
unittests 74.74% <98.27%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 8, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

This pull request has been accepted and is ready to merge.

Commit hash: f443732

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 87bed04 into tikv:release-7.1 Apr 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants