Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: remove unnecessary comment #8026

Merged
merged 1 commit into from
Apr 7, 2024
Merged

resource_control: remove unnecessary comment #8026

merged 1 commit into from
Apr 7, 2024

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4399

What is changed and how does it work?

after #7042, we can remove this.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@CabinfeverB
fix
ded6267 
Signed-off-by: Cabinfever_B <[email protected]>
@CabinfeverB CabinfeverB requested a review from nolouch April 7, 2024 04:28
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 7, 2024
@CabinfeverB CabinfeverB added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 7, 2024 •
edited
Loading

Codecov Report

Merging #8026 (ded6267) into master (7179657) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8026      +/-   ##
==========================================
- Coverage   73.68%   73.67%   -0.01%     
==========================================
  Files         436      436              
  Lines       48525    48525              
==========================================
- Hits        35754    35752       -2     
+ Misses       9723     9722       -1     
- Partials     3048     3051       +3
Flag Coverage Δ
unittests 73.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 7, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ded6267

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit a173a08 into tikv:master Apr 7, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CabinfeverB @nolouch