Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/controller: add logs and export more information in throttled error (#8028) #8255

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8028

What problem does this PR solve?

Issue Number: Ref #7509

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 5, 2024
@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jun 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and nolouch June 5, 2024 08:34
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
Signed-off-by: nolouch <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (c2928cd) to head (4cf0562).

Current head 4cf0562 differs from pull request most recent head aa4e30c

Please upload reports for the commit aa4e30c to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #8255      +/-   ##
===============================================
- Coverage        74.72%   74.58%   -0.15%     
===============================================
  Files              444      444              
  Lines            48269    48266       -3     
===============================================
- Hits             36070    35998      -72     
- Misses            9019     9075      +56     
- Partials          3180     3193      +13     
Flag Coverage Δ
unittests 74.58% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp
Copy link
Member

HuSharp commented Jun 7, 2024

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 19, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-19 03:20:37.740414193 +0000 UTC m=+171364.225903025: ☑️ agreed by JmPotato.
  • 2024-06-19 03:21:57.026970289 +0000 UTC m=+171443.512459121: ☑️ agreed by HuSharp.

Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 2807999 into tikv:release-7.5 Jun 19, 2024
21 checks passed
@HuSharp HuSharp deleted the cherry-pick-8028-to-release-7.5 branch June 19, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants