client: clean up the tls config for client #8347
Conversation
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
ti-chi-bot
added
the
needs-cherry-pick-release-7.1
rleungx
removed
the
needs-cherry-pick-release-7.1
ti-chi-bot
added
the
needs-cherry-pick-release-7.1
| @@ -47,21 +47,12 @@ import ( | |||
| type TLSInfo struct { | |||
| CertFile string | |||
| KeyFile string | |||
| CAFile string // TODO: deprecate this in v4 | |||
There was a problem hiding this comment.
Does it work if there is no CAfile? like pdctl no specified the --cacert.
There was a problem hiding this comment.
https://github.com/tikv/pd/pull/8347/files#diff-91dc9b32b58d11d334b55b1e6fdc4495c5d28d42f125320b8611d43238799bbcR160 still works. It will be assigned to TrustedCAFile.
rleungx
removed
the
needs-cherry-pick-release-7.1
|
@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/merge |
|
@rleungx: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, niubell, nolouch, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8347 +/- ##
==========================================
+ Coverage 77.16% 77.23% +0.06%
==========================================
Files 470 470
Lines 61654 61652 -2
==========================================
+ Hits 47578 47616 +38
+ Misses 10490 10457 -33
+ Partials 3586 3579 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
There are some useless configs which are exposed to the user.
Check List
Tests
Release note