metrics: use second as the unit of latency #8367
Conversation
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8367 +/- ##
==========================================
- Coverage 77.41% 77.23% -0.19%
==========================================
Files 470 470
Lines 61686 61686
==========================================
- Hits 47755 47641 -114
- Misses 10357 10457 +100
- Partials 3574 3588 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -139,7 +139,7 @@ func (s *pdTSOStream) processRequests( | |||
| } | |||
| return | |||
| } | |||
| tsoBatchSendLatency.Observe(float64(time.Since(batchStartTime))) | |||
| tsoBatchSendLatency.Observe(time.Since(batchStartTime).Seconds()) | |||
There was a problem hiding this comment.
If the time delta is less than 1 second, will we got zero as the value of Observe?Is it expected?
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
These metrics are not displayed in the Grafana.
Check List
Tests
Release note