Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiutil/middleware: add retry logic for obtaining PD leader in redirector (#8216) #8466

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 31, 2024

This is an automated cherry-pick of #8216

What problem does this PR solve?

Issue Number: close #8142. Adopted #8407 also.

What is changed and how does it work?

Add retry logic to improve PD HTTP request forwarding success rate during PD leader switch.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot added component/api HTTP API. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 31, 2024
@JmPotato JmPotato force-pushed the cherry-pick-8216-to-release-8.1 branch from 5cb0d52 to 97da4ea Compare August 1, 2024 03:12
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-01 03:12:52.354326019 +0000 UTC m=+411888.634374075: ☑️ agreed by JmPotato.
  • 2024-08-01 03:14:00.025634919 +0000 UTC m=+411956.305682990: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 18892e5 into tikv:release-8.1 Aug 1, 2024
21 checks passed
@JmPotato JmPotato deleted the cherry-pick-8216-to-release-8.1 branch August 1, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/api HTTP API. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants