Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace path with filepath #8488

Merged
merged 2 commits into from
Aug 5, 2024
Merged

*: replace path with filepath #8488

merged 2 commits into from
Aug 5, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 5, 2024

What problem does this PR solve?

Issue Number: Ref #8475

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Aug 5, 2024
@rleungx rleungx changed the title *: replace path *: replace path with filepath Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-05 07:17:46.222232102 +0000 UTC m=+249996.089331190: ☑️ agreed by lhy1024.
  • 2024-08-05 07:26:25.013360452 +0000 UTC m=+250514.880459536: ☑️ agreed by JmPotato.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (73eb0d5) to head (5bd1a40).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8488      +/-   ##
==========================================
+ Coverage   77.30%   77.35%   +0.04%     
==========================================
  Files         472      472              
  Lines       61789    61789              
==========================================
+ Hits        47768    47794      +26     
+ Misses      10445    10428      -17     
+ Partials     3576     3567       -9     
Flag Coverage Δ
unittests 77.35% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit bf501d8 into tikv:master Aug 5, 2024
24 of 25 checks passed
@rleungx rleungx deleted the filepath branch August 5, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants