Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr-autosync: add recover timeout (#6295) #8775

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6295

What problem does this PR solve?

Issue Number: close #4939.

What is changed and how does it work?

add a configuration item to delay dr state switch from async to sync-recover

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (a385ada) to head (adf0f22).
Report is 1 commits behind head on release-7.1.

Files with missing lines Patch % Lines
server/replication/replication_mode.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #8775      +/-   ##
===============================================
- Coverage        74.82%   74.76%   -0.07%     
===============================================
  Files              412      412              
  Lines            41974    41980       +6     
===============================================
- Hits             31409    31387      -22     
- Misses            7810     7837      +27     
- Partials          2755     2756       +1     
Flag Coverage Δ
unittests 74.76% <75.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 05:49:23.043353905 +0000 UTC m=+1106475.882509443: ☑️ agreed by rleungx.
  • 2024-11-08 06:01:57.291537854 +0000 UTC m=+1193630.130693404: ☑️ agreed by lhy1024.

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member

rleungx commented Nov 11, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 11, 2024
@rleungx
Copy link
Member

rleungx commented Nov 11, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit d347eed into tikv:release-7.1 Nov 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants