Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allSettled is out of sync with Promise.allSettled #545

Open
pgengler opened this issue Sep 11, 2019 · 0 comments
Open

allSettled is out of sync with Promise.allSettled #545

pgengler opened this issue Sep 11, 2019 · 0 comments

Comments

@pgengler
Copy link

(Apologies if this has been addressed somewhere; I searched but didn't find anything.)

The allSettled implementation in rsvp returns an object with a state key to indicate whether the corresponding promise was "fulfilled" or "rejected". However, the Stage 4 TC39 proposal for Promise.allSettled uses status as the key, so the two aren't compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant