Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the dispatcher job to use Active Job's rescue_from API #1

Open
chancancode opened this issue Nov 21, 2017 · 0 comments
Open

Comments

@chancancode
Copy link
Member

chancancode commented Nov 21, 2017

We can refactor this rescue block to use Active Job's rescue_from API.

The main motivation for this (making the code more idiomatic is a nice bonus) is to avoid the automatic retry behavior in Sidekiq. It is not usually useful (and very confusing) to retry the commands. According to this it seems like handling errors manually will stop Sidekiq from retrying automatically, as long as we don't call retry_job.

@chancancode chancancode changed the title Refactor the dispatcher job to use Active Job Refactor the dispatcher job to use Active Job's rescue_from API Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant