[Question][BUG] How to use new format.sh

[tzj-fxz]

Required prerequisites

• I have read the documentation https://tilelang.com.
• I have searched the Issue Tracker that this hasn't already been reported. (comment there if it has.)

Questions

PR #1044 has refactored the format.sh for the new version lint. But I'm confused about using it.

When I stash all modified files (with some untracked files left) and commit them, the format.sh does not work as before.

(tilelang) tzj@ubuntu:~/tilelang$ git stash
No local changes to save
(tilelang) tzj@ubuntu:~/tilelang$ ./format.sh 
Detected uncommitted changes. Please commit or stash them before running format.sh.

Could you please offer some insights on how to use the new format script. Thanks. @XuehaiPan

[XuehaiPan]

stash all modified files (with some untracked files left)

I'll send a new PR to resolve this case.

Could you please offer some insights on how to use the new format script.

@tzj-fxz As a temporary solution, you can use:

bash format.sh --all

It runs even a bit faster than format.sh (no-args) due to not querying the remote for merge base hash.

[LeiWang1999]

@XuehaiPan One thing I noticed after running format.sh --all is that pre-commit hooks get installed, which forces developers to auto-format on every commit. From vLLM’s development experience, this isn’t convenient — we should consider remove it

▶ git commit -m "a"            
check for broken symlinks............................(no files to check)Skipped
detect destroyed symlinks............................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
check for merge conflicts............................(no files to check)Skipped
detect private key...................................(no files to check)Skipped
check yaml...........................................(no files to check)Skippe

[XuehaiPan]

we should consider remove it

@LeiWang1999 Resolved in #1102.

To uninstall the git hooks, you can do:

pre-commit uninstall