From 14899c9e93daee37bbfb9fe7a1623040a099ad9d Mon Sep 17 00:00:00 2001 From: James E Keenan Date: Fri, 30 Apr 2021 23:40:42 +0000 Subject: [PATCH] Remove unnecessary definitions in Makefile.PL These 2 NYTPROF_* targets don't need to be defined outside the scope of a particular 'make' target. Defining them may interfere with, e.g., .appveyor.yml. --- Makefile.PL | 2 -- t/90-pod.t | 7 ++++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 05d0417b..4b63f54e 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -283,8 +283,6 @@ perltidy: ctidy_bcpp: bcpp -f 2 -i 4 -bcl -qb 10 -ylcnc -yb NYTProf.xs -NYTPROF_AUTHOR_TESTING="" -NYTPROF_TEST_SHORT="" test_short: NYTPROF_TEST_SHORT=1 NYTPROF_AUTHOR_TESTING=1 make test diff --git a/t/90-pod.t b/t/90-pod.t index 584e3431..bca51ef9 100644 --- a/t/90-pod.t +++ b/t/90-pod.t @@ -1,7 +1,12 @@ #!perl -w use Test::More; -plan skip_all => "NYTPROF_AUTHOR_TESTING only" unless $ENV{NYTPROF_AUTHOR_TESTING}; +unless ($ENV{NYTPROF_AUTHOR_TESTING}) { + plan skip_all => "NYTPROF_AUTHOR_TESTING only"; +} +else { + diag("Relevant envvar is true; proceeding to testing POD"); +} eval "use Test::Pod 1.00"; plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;