Issues discovered on Mac OS X

[smpeters]

I was able to compile the most recent Github version and everything worked fine. That said, there were a few issues.

• Makefile.PL said Warning: prerequisite JSON::MaybeXS 0 not found. . If everything compiles and all the tests pass it is either not a real prerequisite or there is no test coverage for code where JSON::MaybeXS is required.
• NYTProf.xs:1220:1: warning: unused function 'get_str_id' [-Wunused-function]
• several vararg warnings are displayed similar to

NYTProf.xs:3999:20: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
      [-Wvarargs]
    va_start(args, tag);

[jkeenan]

I was able to compile the most recent Github version and everything worked fine. That said, there were a few issues.

* `Makefile.PL` said `Warning: prerequisite JSON::MaybeXS 0 not found.` . If everything compiles and all the tests pass it is either not a real prerequisite or there is no test coverage for code where `JSON::MaybeXS` is required.

[snip]

NYTProf.xs:3999:20: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
      [-Wvarargs]
    va_start(args, tag);

$ ack 'JSON::MaybeXS' bin lib t
bin/nytprofhtml
70:my $has_json = eval { require JSON::MaybeXS; JSON::MaybeXS->import(); 1 }
71:    or warn "Can't load JSON::MaybeXS module - HTML visualizations skipped ($@)\n";
873:        print $fh q{<br/>(Can't create visual treemap of subroutine exclusive times without the <a href="http://metacpan.org/release/JSON-MaybeXS/">JSON::MaybeXS</a> module.)<br/>};

[jkeenan]

I was able to compile the most recent Github version and everything worked fine. That said, there were a few issues.

* `Makefile.PL` said `Warning: prerequisite JSON::MaybeXS 0 not found.` . If everything compiles and all the tests pass it is either not a real prerequisite or there is no test coverage for code where `JSON::MaybeXS` is required.

Previously responded to.

* `NYTProf.xs:1220:1: warning: unused function 'get_str_id' [-Wunused-function]`

* several vararg warnings are displayed similar to

NYTProf.xs:3999:20: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
      [-Wvarargs]
    va_start(args, tag);

I don't have access to Mac OS X. Can you tell me what C-compiler you were using and what version thereof? Thanks.