-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Nodes with names consisting of numbers and single underscores are considered as numbers #12
Comments
Could you post the output file with node "19_3"? Just a short run. |
@timcera I will create a sample snippet and post the file and the run here once I have access to the data on Monday again. |
I will take a look at this. I can include some logic to not convert to float or int for swmmtoolbox. |
@timcera I'm also running into this issue. I've confirmed that the bug is in |
A PR would be great! First choice would be to remove using A close second choice would be to move processing of Third choice would be to add a keyword to Any help would be appreciated. Just so there isn't duplication of effort, I might be able to work on this next week and I am going to explore the second choice because that might help with some of my other toolboxes. However, any help is appreciated and if you have some idea or workaround that you can put together into a PR that solves your problem that would be fantastic. |
@matmair and @lucashtnguyen could you try 4.0.14 that I posted to pypi last night? Should be available from conda-forge in a little bit. I implemented the second choice from above. I now enforce in the Python API that labels must be a list of list like I don't have a test for this bug and I wondered if either of you can send me a small output file with a node or link name that would trigger this problem. |
Hi @timcera, thanks for coordinating with @lucashtnguyen and making this fix. 4.0.14 works for our needs this functions in 4.0.14 but was failing in 4.0.13 (different calling syntax) Thanks |
Hi there @timcera !
Thank you for this great software. I ran into the following problem today:
'node,19_3,Depth_above_invert'
leads to the node label beeing interpreted as193
in acordance to https://peps.python.org/pep-0515/.The issues seems to be part of
tsutils.make_list
. I will leave a comment with a solution if I find any.The text was updated successfully, but these errors were encountered: