Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more Profile? #111

Open
aburrell opened this issue Jul 1, 2019 · 4 comments
Open

No more Profile? #111

aburrell opened this issue Jul 1, 2019 · 4 comments

Comments

@aburrell
Copy link

aburrell commented Jul 1, 2019

Profile functionality was removed, was this intentional?

@bharding512
Copy link
Collaborator

I don't think this pull request was ever accepted: #25

@timduly4
Copy link
Owner

timduly4 commented Jul 1, 2019

It is almost trivial to put this back in (e.g.):

class Profile:
    def __init__(self, dn, lat, lon, start_height, end_height, spacing=1):
        altitudes = range(start_height, end_height, spacing)
        self.points = [Point(dn, lat, lon, altitude) for altitude in altitudes)

@aburrell
Copy link
Author

aburrell commented Jul 1, 2019

It would be nice to have (back) in, since it's how I've continued to use pyglow.

In light of #25 never being accepted, a pull request that stale should probably be closed.

@timduly4
Copy link
Owner

timduly4 commented Jul 1, 2019

We'll keep this as an outstanding issue, then. For better or worse, I'm behind on several pyglow issues at the moment-- these are the perils of an open-source project...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants