Support attach and detach exporters from service #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronblevy
force-pushed
the
aaron/attach_detatch_exporter
branch
2 times, most recently
from
64da386 to
a1e3c87
Compare
This adds support for attach and detaching exporters from service. This is supported using two new fields on the service resource, metric_exporter_id and log_exporter_id. This change also adds a data source to import existing exporters by name.
aaronblevy
force-pushed
the
aaron/attach_detatch_exporter
branch
from
a1e3c87 to
51882d3
Compare
RobAtticus
approved these changes
Apr 23, 2024
Khyme
requested changes
Apr 25, 2024
|
|
||
| ### Required | ||
|
|
||
| - `name` (String) The name of this exporter. Exporter names must be unique in order to manage them using Terraform. |
There was a problem hiding this comment.
Since we can have exporters with the same name, this isn't right
There is no issue with having two exporters with the same name since they're managed (ie attached) using the ids
There was a problem hiding this comment.
there was an internal meeting where we decided to go forward with import by name, otherwise we'll have to start showing IDs in the UI. This seems similar to have VPC works? It also fetches VPCs by name and I don't see VPC IDs in the UI
There was a problem hiding this comment.
yes but names are unique for vpc by design
There was a problem hiding this comment.
is the solution you're thinking of to show IDs in the UI?
Khyme
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for attach and detaching exporters from service. This is supported using two new fields on the service resource, metric_exporter_id and log_exporter_id. This change also adds a data source to import existing exporters by name.
Issues