Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tink-worker] The version in the logs is not properly set #810

Open
jacobweinstock opened this issue Oct 8, 2023 · 0 comments
Open

[tink-worker] The version in the logs is not properly set #810

jacobweinstock opened this issue Oct 8, 2023 · 0 comments

Comments

@jacobweinstock
Copy link
Member

Tink worker builds for container images pushed to quay.io/tinkerbell/tink-worker do not properly set the version. As a consequence, the container starts up with a log line showing the version to be devel. This devel is actually just hard-coded:

var version = "devel"

Expected Behaviour

The version reflects the tag or commit sha of the code from which it was built.

Current Behaviour

See the summary above.

Possible Solution

If we are to include the version, which I think is a good thing, we should set the version properly to a tag or commit sha.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant