Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tn-cli for better readability and wider usage #917

Open
THUzxj opened this issue Aug 20, 2024 · 1 comment
Open

Refactor tn-cli for better readability and wider usage #917

THUzxj opened this issue Aug 20, 2024 · 1 comment

Comments

@THUzxj
Copy link

THUzxj commented Aug 20, 2024

Is your feature request related to a problem? Please describe.

I want to interact with tinode with Python. tn-cli provides a python client implementation, but it is hard to read and use because:

  • the single tn-cli.py file is too long
  • the cli function and the python function is coupled

Describe the solution you'd like

I want to help to refactor the single file program to python modules, decoupling the cli functions and the python sdk functions.

Describe alternatives you've considered

None.

Additional context

None.

@or-else
Copy link
Contributor

or-else commented Aug 22, 2024

I suppose it's not a bad idea to split CLI from Tinode methods. If you decide to do it, please follow these two suggestions:

  1. All PRs should be against devel branch.
  2. Please do gradual refactoring, i.e. in small chunks so it would be easier to review and make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants