From f6559ec7adc6212d924dccbe47b34a3f1180226d Mon Sep 17 00:00:00 2001 From: abhinavgandham Date: Fri, 17 Jan 2025 13:27:43 +0530 Subject: [PATCH 1/8] DOC-2609: Resizing images by typing into the input didn't update the attribute correctly. --- modules/ROOT/pages/7.6.1-release-notes.adoc | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index 04950c4f02..cd01ba4661 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -101,6 +101,25 @@ In {productname} {release-version}, this issue has been resolved by ensuring the For information on the **Enhanced Table** plugin, see: xref:advtable.adoc[Enhanced Tables]. +=== Image Optimizer + +The {productname} {release-version} release includes an accompanying release of the **Image Optimizer** premium plugin. + +**Image Optimizer** includes the following fixes. + +==== Resizing images by typing into the input didn't update the `style` attribute correctly. + +An issue was identified where the `data-mce-style` attribute of an image was not updated correctly when its width and height were modified via user input. + +This was caused by triggering the resize function when the selection was somewhere else due to a debounce between the input and the resize, but the resize operation would be performed on the current selection. + +This resulted in other editor components that contain the `data-mce-style` attribute accidentally reading outdated values, and the resize not being applied as the selection would not be on the image. + +{productname} {release-version} addresses this by updating the `data-mce-style` attribute accordingly when a resize operation is performed and the resize function takes the image as a parameter. +This ensures that all editor components that reference the `data-mce-style` attribute read the most recent value entered, and the resize operation is applied to the correct image even before the debounce time has elapsed. + +For information on the **Image Optimizer** plugin, see: xref:uploadcare.adoc[Image Optimizer]. + [[accompanying-premium-plugin-end-of-life-announcement]] == Accompanying Premium plugin end-of-life announcement From 216ed511119e998471fe8094d1506e114e35531c Mon Sep 17 00:00:00 2001 From: "CODE:AG" <57781325+abhinavgandham@users.noreply.github.com> Date: Fri, 17 Jan 2025 13:34:56 +0530 Subject: [PATCH 2/8] Update modules/ROOT/pages/7.6.1-release-notes.adoc --- modules/ROOT/pages/7.6.1-release-notes.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index cd01ba4661..08da00f5d3 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -104,7 +104,7 @@ For information on the **Enhanced Table** plugin, see: xref:advtable.adoc[Enhanc === Image Optimizer The {productname} {release-version} release includes an accompanying release of the **Image Optimizer** premium plugin. - +// TINY-11669 **Image Optimizer** includes the following fixes. ==== Resizing images by typing into the input didn't update the `style` attribute correctly. From 366657f3905f4bf26aa1765df7ec4095790e3787 Mon Sep 17 00:00:00 2001 From: abhinavgandham Date: Fri, 17 Jan 2025 13:37:03 +0530 Subject: [PATCH 3/8] Added ticket number to entry. --- modules/ROOT/pages/7.6.1-release-notes.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index 08da00f5d3..c762bdc2da 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -104,10 +104,11 @@ For information on the **Enhanced Table** plugin, see: xref:advtable.adoc[Enhanc === Image Optimizer The {productname} {release-version} release includes an accompanying release of the **Image Optimizer** premium plugin. -// TINY-11669 + **Image Optimizer** includes the following fixes. ==== Resizing images by typing into the input didn't update the `style` attribute correctly. +// TINY-11669 An issue was identified where the `data-mce-style` attribute of an image was not updated correctly when its width and height were modified via user input. From 8663e6de83e15c2bd4a8b9bc899df92f7636999f Mon Sep 17 00:00:00 2001 From: abhinavgandham Date: Fri, 17 Jan 2025 18:33:49 +0530 Subject: [PATCH 4/8] Improved wording and removed the reference of the attribute's name. --- modules/ROOT/pages/7.6.1-release-notes.adoc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index c762bdc2da..13dd7f3c37 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -110,14 +110,13 @@ The {productname} {release-version} release includes an accompanying release of ==== Resizing images by typing into the input didn't update the `style` attribute correctly. // TINY-11669 -An issue was identified where the `data-mce-style` attribute of an image was not updated correctly when its width and height were modified via user input. +An issue was identified where the `style` attribute of an image was not updated correctly when its width and height were modified via user input. -This was caused by triggering the resize function when the selection was somewhere else due to a debounce between the input and the resize, but the resize operation would be performed on the current selection. +This occurred because the resize function was triggered while the selection was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image. -This resulted in other editor components that contain the `data-mce-style` attribute accidentally reading outdated values, and the resize not being applied as the selection would not be on the image. +This led to other editor components that rely on the `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image. -{productname} {release-version} addresses this by updating the `data-mce-style` attribute accordingly when a resize operation is performed and the resize function takes the image as a parameter. -This ensures that all editor components that reference the `data-mce-style` attribute read the most recent value entered, and the resize operation is applied to the correct image even before the debounce time has elapsed. +{productname} {release-version} resolves this issue by updating the `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing the `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses. For information on the **Image Optimizer** plugin, see: xref:uploadcare.adoc[Image Optimizer]. From 069f113b397f8799a206b72bab67165359bc7fbc Mon Sep 17 00:00:00 2001 From: "CODE:AG" <57781325+abhinavgandham@users.noreply.github.com> Date: Tue, 21 Jan 2025 13:36:55 +0530 Subject: [PATCH 5/8] Update modules/ROOT/pages/7.6.1-release-notes.adoc --- modules/ROOT/pages/7.6.1-release-notes.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index 13dd7f3c37..f2a407ba4c 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -110,7 +110,7 @@ The {productname} {release-version} release includes an accompanying release of ==== Resizing images by typing into the input didn't update the `style` attribute correctly. // TINY-11669 -An issue was identified where the `style` attribute of an image was not updated correctly when its width and height were modified via user input. +An issue was identified where the internal custom `style` attribute of an image was not updated correctly when its width and height were modified via user input. This occurred because the resize function was triggered while the selection was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image. From b861eaf6cbd841cad9d6fcad7c54762605f205a8 Mon Sep 17 00:00:00 2001 From: "CODE:AG" <57781325+abhinavgandham@users.noreply.github.com> Date: Tue, 21 Jan 2025 13:44:37 +0530 Subject: [PATCH 6/8] Update modules/ROOT/pages/7.6.1-release-notes.adoc --- modules/ROOT/pages/7.6.1-release-notes.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index f2a407ba4c..33a5758a4a 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -116,7 +116,7 @@ This occurred because the resize function was triggered while the selection was This led to other editor components that rely on the `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image. -{productname} {release-version} resolves this issue by updating the `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing the `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses. +{productname} {release-version} resolves this issue by updating that custom `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing that custom `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses. For information on the **Image Optimizer** plugin, see: xref:uploadcare.adoc[Image Optimizer]. From 4fd4a92490e07e0318f3ef11c6639e4f787b38dc Mon Sep 17 00:00:00 2001 From: "CODE:AG" <57781325+abhinavgandham@users.noreply.github.com> Date: Tue, 21 Jan 2025 13:44:44 +0530 Subject: [PATCH 7/8] Update modules/ROOT/pages/7.6.1-release-notes.adoc --- modules/ROOT/pages/7.6.1-release-notes.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index 33a5758a4a..e5b90565bd 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -114,7 +114,7 @@ An issue was identified where the internal custom `style` attribute of an image This occurred because the resize function was triggered while the selection was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image. -This led to other editor components that rely on the `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image. +This led to other editor components that rely on that custom `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image. {productname} {release-version} resolves this issue by updating that custom `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing that custom `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses. From c9a740461ac99cd024d02e20dac9cee3debbbe71 Mon Sep 17 00:00:00 2001 From: "CODE:AG" <57781325+abhinavgandham@users.noreply.github.com> Date: Tue, 21 Jan 2025 15:27:39 +0530 Subject: [PATCH 8/8] Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard --- modules/ROOT/pages/7.6.1-release-notes.adoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/ROOT/pages/7.6.1-release-notes.adoc b/modules/ROOT/pages/7.6.1-release-notes.adoc index e5b90565bd..7a9f51f88c 100644 --- a/modules/ROOT/pages/7.6.1-release-notes.adoc +++ b/modules/ROOT/pages/7.6.1-release-notes.adoc @@ -110,13 +110,13 @@ The {productname} {release-version} release includes an accompanying release of ==== Resizing images by typing into the input didn't update the `style` attribute correctly. // TINY-11669 -An issue was identified where the internal custom `style` attribute of an image was not updated correctly when its width and height were modified via user input. +An issue was identified where an internal custom `style` attribute of an image was not updated correctly after a user modified its width and height. -This occurred because the resize function was triggered while the selection was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image. +This issue occurred because the resize function was triggered while the selection focus was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image. -This led to other editor components that rely on that custom `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image. +This led to other editor components that rely on that custom `style` attribute to accidentally read outdated values, resulting in the resize not being applied correctly since the selection was not on the intended image. -{productname} {release-version} resolves this issue by updating that custom `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing that custom `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses. +{productname} {release-version} addresses this issue, by updating the custom `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing that custom `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses. For information on the **Image Optimizer** plugin, see: xref:uploadcare.adoc[Image Optimizer].