Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests? #53

Open
saschanaz opened this issue Jun 18, 2023 · 6 comments
Open

More tests? #53

saschanaz opened this issue Jun 18, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@saschanaz
Copy link

This doesn't seem to have many tests 👀

@EugeneVert
Copy link
Contributor

Thanks for your interest in jxl-oxide!

We currently running tests against the libjxl's conformance repository and have several custom regression tests.
https://github.com/tirr-c/jxl-oxide/tree/main/crates/jxl-oxide/tests

Do you have any suggestions as to what tests would be desirable?

@saschanaz
Copy link
Author

saschanaz commented Jun 18, 2023

Thanks, I totally missed that part!

Still I see many test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s messages in the CI job and those files indeed have no unit tests. Would be great to have some!

I wonder how the current test coverage is, is there some setup to track the coverage?

@tirr-c
Copy link
Owner

tirr-c commented Jun 19, 2023

Currently we have:

  • unit tests for DCT and IDCT (small, basic cases),
  • integration tests for the crate jxl-oxide:
  • and doc tests for jxl-oxide (these are compile-only tests).

I think most of the code are covered by the integration tests, so I didn't write unit tests that much. However I do think there are some components that would benefit from unit tests, such as entropy decoder. (Contributions are welcome!)

There is no code coverage setup, but one can collect coverage by following the documentation.

@tirr-c tirr-c added the enhancement New feature or request label Jun 19, 2023
@saschanaz
Copy link
Author

saschanaz commented Jun 19, 2023

There is no code coverage setup, but one can collect coverage by following the documentation.

Any intent to use something like Codecov to track the coverage? I'm considering to migrate to this from libjxl (for https://github.com/saschanaz/jxl-winthumb) and having to build to get the current coverage is not ideal to me.

@tirr-c
Copy link
Owner

tirr-c commented Jun 19, 2023

Created #55 to track it. Thanks for the suggestion!

@tirr-c
Copy link
Owner

tirr-c commented Jun 20, 2023

Coverage can be checked here. I hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants