Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in examples/train_embedding.py(P2) #25

Open
DLPerf opened this issue Aug 20, 2021 · 0 comments
Open

Performance issues in examples/train_embedding.py(P2) #25

DLPerf opened this issue Aug 20, 2021 · 0 comments

Comments

@DLPerf
Copy link
Contributor

DLPerf commented Aug 20, 2021

Hello,I found a performance issue in tf-TabNet/blob/master/examples/train_embedding.py
ds_train.map was called without num_parallel_calls.
I think it will increase the efficiency of your program if you add this.

The same issues also exist in ds_test = ds_test.map

Here is the documemtation of tensorflow to support this thing.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf DLPerf changed the title Performance issues in examples/train_embedding.py Performance issues in examples/train_embedding.py(P2) Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant