Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in /examples/train_embedding.py (by P3) #27

Open
DLPerf opened this issue Aug 27, 2021 · 0 comments
Open

Performance issues in /examples/train_embedding.py (by P3) #27

DLPerf opened this issue Aug 27, 2021 · 0 comments

Comments

@DLPerf
Copy link
Contributor

DLPerf commented Aug 27, 2021

Hello! I've found a performance issue in /examples/train_embedding.py: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

  • ds_train = ds_train.batch(BATCH_SIZE)(line 33) should be called before ds_train = ds_train.map(transform)(line 32).
  • ds_test = ds_test.batch(BATCH_SIZE)(line 37) should be called before ds_test = ds_test.map(transform)(line 36).

Besides, you need to check the function called in map()(e.g., transform called in ds_test.map(transform)) whether to be affected or not to make the changed code work properly. For example, if transform needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant