Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert from roman to chord #12

Open
titus-ong opened this issue Jul 18, 2020 · 2 comments
Open

Convert from roman to chord #12

titus-ong opened this issue Jul 18, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@titus-ong
Copy link
Owner

Add method to convert from roman notation to a Chord in the ChordRomanConverter class.
@titus-ong titus-ong added the enhancement New feature or request label Jul 18, 2020
@titus-ong
Copy link
Owner Author

Possibly copy over the chord's quality, add, bass when creating Roman. This would make restoring to chord easier since we can create a new chord from all these attributes.

@titus-ong titus-ong added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 26, 2020
@titus-ong titus-ong removed good first issue Good for newcomers help wanted Extra attention is needed labels Aug 31, 2020
@titus-ong
Copy link
Owner Author

titus-ong commented Aug 31, 2020 •
edited
Loading

May become irrelevant if new architecture (#39) for Chord class contains Roman attribute, i.e. they do not need to be converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@titus-ong