Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:headers / :xhr should not be wrapped in :params #13

Open
vongruenigen opened this issue May 14, 2019 · 1 comment
Open

:headers / :xhr should not be wrapped in :params #13

vongruenigen opened this issue May 14, 2019 · 1 comment

Comments

@vongruenigen
Copy link

Thanks a lot for this project! You've saved me (and probably many others) countless hours of brainless rewriting of tests.

But, I have one issue currently: We have quite a lot of tests in our test suite, where we only set the :headers but not the :params:

get users_path, headers: { my_header: 'gugus' }

The tool currently does not correctly recognize that the :headers part should not be wrapped within :params, because the resulting code is:

get users_path, params: { headers: { my_header: 'gugus' } }

I'm probably going to open a PR later for fixing this problem.

@vongruenigen vongruenigen changed the title :headers are wrapped in :params :headers should not be wrapped in :params May 14, 2019
vongruenigen added a commit to vongruenigen/rails5-spec-converter that referenced this issue May 14, 2019
@vongruenigen
Copy link
Author

I just noticed that the :xhr attribute has the same problem and is also wrapped within :params. I'm quickly going to change that in my PR too.

@vongruenigen vongruenigen changed the title :headers should not be wrapped in :params :headers / :xhr should not be wrapped in :params May 14, 2019
vongruenigen added a commit to vongruenigen/rails5-spec-converter that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant