Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning During Compilation: this statement may fall through [-Wimplicit-fallthrough=] #54

Closed
1 task done
barndawgie opened this issue Jul 17, 2024 · 1 comment
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@barndawgie
Copy link

Troubleshooting Guide

  • I have followed the steps in the troubleshooting guide and my issue is either not listed or is not solved.

Description

During compilation for wireless install, I see this warning in the logs.

Logs

src/esphome/components/standing_desk_height/omnidesk_decoder.cpp: In member function 'virtual bool esphome::standing_desk_height::OmnideskDecoder::put(uint8_t)':
src/esphome/components/standing_desk_height/omnidesk_decoder.cpp:9:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
     if (b == 0x02 || b == 0x03 || b == 0x04) {
     ^~
src/esphome/components/standing_desk_height/omnidesk_decoder.cpp:14:3: note: here
   default:
   ^~~~~~~


### Which version of the Upsy Desky firmware config are you running?

v4.0.0

### How do you manage your Upsy Desky's updates?

None

### If you're using an ESPHome YAML config, which version of ESPHome are you running?

2024.7.0

### ESPHome Config

```YAML
---
substitutions:
  name: "upsy-desky-534044"
  friendly_name: "Upsy Desky"
  device_description: "Fully Jarvis Desk Controller"

packages:
  upsy_desky:
    url: https://github.com/tjhorner/upsy-desky
    file: firmware/stock.yaml
    ref: v4.0.0
  base_config: !include config_deps/base_config.yaml # Contains my wi-fi and API secrets

esphome:
  name: ${name}
  name_add_mac_suffix: false
  friendly_name: ${friendly_name}
  comment: ${device_description}

time:
  - platform: homeassistant
    id: homeassistant_time
@barndawgie barndawgie added the bug Something isn't working label Jul 17, 2024
@barndawgie barndawgie changed the title Warning During Complication: this statement may fall through [-Wimplicit-fallthrough=] Warning During Compilation: this statement may fall through [-Wimplicit-fallthrough=] Jul 17, 2024
@35gh
Copy link

35gh commented Jul 22, 2024

Duplicate of #51

@barndawgie barndawgie closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants