-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreaded SocketServer
#106
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
commented
Aug 5, 2022
emostov
commented
Aug 5, 2022
emostov
commented
Aug 5, 2022
Some raw notes from an offline discussion with @r-n-o:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
This PR converts the
SocketServer
to supporting async requests by implementing a thread pool and processing each new socket connection on a new thread.For context, our communication model creates a new connection for each request/response, thus for each request/response we create a new job on a thread and the job finishes once the request is returned.
Why make the server async
Given these goals, pure performance is not the main concern but instead we mainly want to focus on making ours server non-blocking while aligning with our security goals of robust and easy to audit code.
Why a thread pool?
When I set out I originally intended to use
async
Rust code, which does not necessarily imply multithreading but just that code can be executed in a non-blocking way. In order to runasync
code in Rust you need an executor (example), which is not provided by the standard library. Note that executors can be both multithreaded and non blocking on a single thread.There are several popular executors, but the most popular today is probably: https://github.com/tokio-rs/tokio, which implements an async runtime. From what I understand the internals of tokio is quite complex and appears to be a significant review burden.
There are some other options for executors, the simples of which appears to be the
futures
cratethread pool executor
.futures
is an extremely popular crate as it provides many of the shared primitive types used across async runtimes in the Rust ecosystem. However, my thinking here is that we can avoid futures all together by implementing our own thread pool.Relevant reading