Fix gain error #86
Merged
Fix gain error #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've built a release. If this fix works I can create a new "official" release with the image. I could also preemptively do that if you need access to the image to test everything @jusack. Then we just alter overwrite it or something like that |
This was referenced Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compensation for the gain change by the CIC was missing. This results in different scalings when changing decimations.
The result for a simple DC offset looks then like the following picture:
A fix is described in https://support.xilinx.com/s/question/0D52E00006hpfy6SAA/cic-filter-gain?language=en_US. I added this fix to the application of the calibration in the client. The raw data from the server is thus not corrected. This is intended since at that point we are still working with integers. Only after calibration we get floatinbg point numbers.
@jusack Please check if this solves your problem.
@nHackel Could you please create a new release?