Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple Support for Headers #535

Open
eldonferranpol opened this issue Jul 23, 2020 · 2 comments
Open

Tuple Support for Headers #535

eldonferranpol opened this issue Jul 23, 2020 · 2 comments

Comments

@eldonferranpol
Copy link

Intending to put in a pull request for headers to allow for the passing of tuples something along these lines:

request.WithHeaders(("Accept", "application/json"), ("host", "localhost"), ("etc", "etc"))

@tmenier
Copy link
Owner

tmenier commented Sep 30, 2020

(Pulling over some notes from #536.)

Need to evaluate what other areas might benefit from this. Possibilities:

  • SetQueryParams
  • WithHeaders
  • WithCookies
  • AddStringParts (multipart)
  • Various things in HttpCallAssertion

Searching for ToKeyValuePairs is a good way to identify candidates. This doesn't necessarily mean it needs to be added everywhere. Not a breaking change so this doesn't need to get out for 3.0.

@tmenier tmenier removed the 3.0 label Sep 30, 2020
@tmenier tmenier added the 4.0 label May 6, 2022
@tmenier
Copy link
Owner

tmenier commented Sep 12, 2023

Still like this idea but in the interest of time it won't make the initial 4.0 cut. Possibly 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

No branches or pull requests

2 participants