-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent update has left an impossible upgrade conflict with akka #586
Comments
I'm facing the issue regarding |
Yep looks like they (akka) aren't going to fix the issue on their end. |
I have created this issue lightbend/ssl-config#353 in the hope that akka would consider upgrading to We will see |
I would recommend downgrading to If we take a look at the releases notes for 2.x there is nothing relevant worth pulling the update version This is probably why twitter is sticking with the older version |
Support downgrading to 1.1.2 as well. |
Should fix tminglei#586 upon publishing.
Created a PR #587 |
Any updates on this? I just stumbled upon this as well, running scala 2.13.10
|
I guess the only option is forking and publishing it under another organization. |
@tminglei what is stopping you from merging PR #587 ? A fork is not in the interest of anybody.. def mainDependencies(scalaVersion: String) = {
val extractedLibs = CrossVersion.partialVersion(scalaVersion) match {
case Some((3, _)) =>
Seq("org.scala-lang.modules" %% "scala-parser-combinators" % "2.1.1")
case Some((2, scalaMajor)) if scalaMajor >= 11 =>
Seq("org.scala-lang.modules" %% "scala-parser-combinators" % "1.1.2")
case _ =>
Seq()
} |
@domdorn well, I was just waiting for the build failure to be resolved by someone else. Now I'll stop waiting, and move it forward. |
thanks a lot! |
Thank you! When we can expect new release? |
@mikla released to |
This is not necessarily
slick-pg
s responsibility to address, I am detailing it here as it wasslick-pg
's update that revealed the problem.If you have the following installed dependencies:
And you upgrade
slick-pg
to0.21.0 (latest)
you get the following incompatibility:This is because
akka-stream
keeps you at an oldssl-config-core
version until you have upgraded to scala 3. This then includes an old version ofscala-parser-combinators
, causing the conflict.The inability to update
slick-pg
also prevents you updating toslick 3.4.0 (latest)
:This means for example that when work begins on
slick
for scala 3, users ofakka-stream
andslick-pg
will be unable to upgrade in good time to a cross compatible version, making the ultimate migration to scala 3 much more difficult than it needs to be.As it stands, dropping use of this library is our easiest and safest path forward, which I really do not want to do
The text was updated successfully, but these errors were encountered: