Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Modify" instead of "ADD" #18

Open
tobiasbrisach opened this issue Feb 24, 2021 · 4 comments
Open

"Modify" instead of "ADD" #18

tobiasbrisach opened this issue Feb 24, 2021 · 4 comments

Comments

@tobiasbrisach
Copy link

Thanks for this awesome tool. Does perfectly what it should do.

One little feature I would like to ask for: Is it possible to use the tool for modifying, too?

So I could make modifications in the excel and the scripts pushes them to the FMG without me deleting all devices in first?

And to make it even greater, use it to replace devices by changing the serial number in the excel?

Thanks for the great work and the time you spend with it.

@tmorris-ftnt
Copy link
Owner

Hi, Thanks for the feedback!

Allowing modification should be easy enough, it might need to be an option as some users rely on the fact it will fail if the device already exists.

Changing the SN of a device that already exists isn't doable via the API as far as I know.

@tobiasbrisach
Copy link
Author

Hi Tim,

a colleague of mine (you already had contact with him in Issue #17) found some API Commands for replacing a devices:

image

Does this help?

@tmorris-ftnt
Copy link
Owner

I cant get that API command to work for either a model device or a real device, the CLI version of it works (exec device replace sn).

How do you think it would work if it detects a model device with the same name in the same ADOM you're trying to add that it just deletes the device automatically then re-adds it with the new information provided?

For the update feature are you looking at this for model devices or for devices after they have been deployed? I can see if being useful if you wanted to push out an update and you needed to add or update meta-fields to existing devices.

@tobiasbrisach
Copy link
Author

I think the best would be, that if the device already exist, but differs from the excel data, it will be modified without being deleted in front.

If it is a modell device, it makes not difference for me if it is deleted automatically during the process.

But if it is an already deploy device deletion and redeploy could cause problems.

Perhaps it is possible to have only one process for deploying and modifying, so the tool would add for non existent and modify for existing devices in one run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants