Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build instructions for newcorners #232

Open
rtxa opened this issue Jul 20, 2024 · 2 comments
Open

Add build instructions for newcorners #232

rtxa opened this issue Jul 20, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@rtxa
Copy link

rtxa commented Jul 20, 2024

Hi tmp64, I'm just trying to build the project in Windows using VS 2022 but I didn't found any guide like in the old repository https://github.com/tmp64/BugfixedHL/wiki/Building-guide

I cloned the repository with Github Desktop and I used the command line with the next cmd cmake -B build -DNO_SIZEOF_VOID_P_CHECK=ON. It builds the project, but I can't compile, I'm not sure how to tell CMake to build the project using MSVC of 32 bits instead of using 64 bits. Using CMake GUI instead I was able to compile it.

@tmp64 tmp64 added question Further information is requested documentation Improvements or additions to documentation labels Jul 20, 2024
@tmp64
Copy link
Owner

tmp64 commented Jul 20, 2024

You must never use NO_SIZEOF_VOID_P_CHECK. I should probably remove it altogether. If it shows that error, it means that you're building for a 64-bit platform. HL is 32-bit so it doesn't make sense to do that.

With CMake GUI, select Win32 instead of x64 in this dialog .

321842176-7c57129f-070b-4697-8289-1b45a199aa10

But I agree I should make a build guide. In the meantime, anyone interested can follow this guide that I made for a different project. But keep this in mind:

  1. Don't install vcpkg. It's not required.
  2. Don't install MFC/ATL. They're not required.
  3. Use this repo's Git URL: https://github.com/tmp64/BugfixedHL-Rebased.git

@rtxa
Copy link
Author

rtxa commented Jul 20, 2024

Thanks, maybe you shouldn't remove the warning but make it more meaningful. I figured out how to use Win32 from command line: cmake -B build -A Win32 and now everything works as expected.

@tmp64 tmp64 added this to the v1.11.0 milestone Aug 22, 2024
@tmp64 tmp64 removed this from the v1.11.0 milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants