Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trial: composite #25

Merged
merged 6 commits into from
Mar 21, 2024
Merged

trial: composite #25

merged 6 commits into from
Mar 21, 2024

Conversation

tnyo43
Copy link
Owner

@tnyo43 tnyo43 commented Mar 20, 2024

use composite runner to make .github/workflows script simpler

@tnyo43 tnyo43 changed the title trial composite trial: composite Mar 20, 2024
Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment


getInput is not working ... 🤔

Run node ${GITHUB_ACTION_PATH}/dist/index.js
node ${GITHUB_ACTION_PATH}/dist/index.js
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Error: Input required and not supplied: github_token
Error: Process completed with exit code 1.
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8367297431/job/22909352478

Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment


works fine 👍

Run node ${GITHUB_ACTION_PATH}/dist/index.js
******* DEBUG is ENABLED *******
option {
token: '***',
prNumber: 25,
threshold: 4,
debug: true
}
number of the obtained comments is 2
It's not necessary to send a recommending comment yet.
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8367347978/job/22909520042

Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment


Ok, it seems I need to keep uses: actions/checkout@v4 in test-action.yml

Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/recommend-mobpro-action/recommend-mobpro-action'. Did you forget to run actions/checkout before running your local action?
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8367398944/job/22909683370

Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment


if is not able to be used...

Error: /home/runner/work/recommend-mobpro-action/recommend-mobpro-action/./action.yml (Line: 22, Col: 3): Unexpected value 'if'
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. /home/runner/work/recommend-mobpro-action/recommend-mobpro-action/./action.yml (Line: 22, Col: 3): Unexpected value 'if'
at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load /home/runner/work/recommend-mobpro-action/recommend-mobpro-action/./action.yml
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8367458612/job/22909866952

Copy link
Owner Author

@tnyo43 tnyo43 Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment


👍
merge this and let's see how it works with "issue_comment" triggered events
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8367729497/job/22910647738

Copy link

Hey @tnyo43!

It seems the discussion is dragging on. Perhaps instead of text communication, you could try having a conversation via face-to-face or video call, or even try mob programming?

@tnyo43 tnyo43 merged commit 9328215 into main Mar 21, 2024
5 checks passed
@tnyo43
Copy link
Owner Author

tnyo43 commented Mar 21, 2024

test comment


the steps are not skipped, this is what I expected 👍
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8367782587/job/22910797420

@tnyo43 tnyo43 deleted the composite branch March 21, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant