Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.2 #363

Closed
7 of 8 tasks
JuliaKukulies opened this issue Nov 8, 2023 · 9 comments
Closed
7 of 8 tasks

Release 1.5.2 #363

JuliaKukulies opened this issue Nov 8, 2023 · 9 comments
Labels
release Organising the next release on conda-forge
Milestone

Comments

@JuliaKukulies
Copy link
Member

JuliaKukulies commented Nov 8, 2023

We are almost ready for the next release. Here is the checklist:

  • Re-run notebooks and commit updates to the repository
  • Bump version in init.py
  • Add changelog
  • Merge RC_v1.5.x into main
  • Delete RC_v1.5.x branch
  • Create release
  • Push release to conda-forge
  • E-mail tobac mailing list
@JuliaKukulies JuliaKukulies added the release Organising the next release on conda-forge label Nov 8, 2023
@freemansw1
Copy link
Member

freemansw1 commented Nov 8, 2023

Do we want to include #362 #361 in 1.5.2? Happy either way...

Edit - meant #361, #362 needs some more discussion.

@freemansw1
Copy link
Member

I also think we should do #347 before release

@JuliaKukulies
Copy link
Member Author

Agreed, I think we can figure out these three PRs/issues before the next release. Added that to the check list!

@fsenf
Copy link
Member

fsenf commented Nov 23, 2023

Hej all, could "Adding checklists for the issue tracker" #358 be considered as part of the v1.5.2 release? @fziegner has nearly finished this PR.

@fsenf
Copy link
Member

fsenf commented Nov 23, 2023

I further added "Introducing pylint in our workflow" #278 to the milestone list for v1.5.2. This work is also more than ready ;-)

@w-k-jones
Copy link
Member

Hej all, could "Adding checklists for the issue tracker" #358 be considered as part of the v1.5.2 release? @fziegner has nearly finished this PR.

We can also merge directly into main outside of a release, but I'm happy to get it in for v1.5.2 as well. Let me know when it's ready and I'll provide a review :)

@JuliaKukulies
Copy link
Member Author

JuliaKukulies commented Nov 28, 2023

Great, @fziegner and @fsenf ! I will have a look at the PR to my fork today and if #358 is ready, happy to provide a review and convert it into a real PR.

I would say if it takes longer than the other remaining issues for v1.5.2, we can directly merge to main after the release to not further postpone the release since these changes only concern our internal workflow. But since this looks quite ready, Id say we can include it in v1.5.2 :)

@w-k-jones w-k-jones added this to the Version 1.5.2 milestone Dec 2, 2023
@w-k-jones
Copy link
Member

Version number, changelog and notebooks updates in #381

@w-k-jones
Copy link
Member

Well, that ended up being mildly painful, but v1.5.2 is now live 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Organising the next release on conda-forge
Projects
None yet
Development

No branches or pull requests

4 participants