Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyproject.toml for package setup #442

Open
w-k-jones opened this issue Aug 12, 2024 · 2 comments · May be fixed by #464
Open

Add pyproject.toml for package setup #442

w-k-jones opened this issue Aug 12, 2024 · 2 comments · May be fixed by #464
Labels
good first issue An ideal issue for new contributors to address workflow Improvements and updates to the repository and CI

Comments

@w-k-jones
Copy link
Member

As using a pyproject.toml file has become standard for python packages, and pip is starting to complain about installing using a setup.py file directly, we should update tobac to the new standard. This shouldn't be too complex, as we can keep the existing setup.py if we are installing using setuptools: https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
@w-k-jones w-k-jones added good first issue An ideal issue for new contributors to address workflow Improvements and updates to the repository and CI labels Aug 12, 2024
@freemansw1
Copy link
Member

Thanks for raising this, @w-k-jones. I think this should be a high priority to get out with 1.6. Given the noise around Anaconda, we may want to consider making tobac available on PiPy at the same time.

@w-k-jones
Copy link
Member Author

I agree, it would be nice to add tobac to PiPy. I think we can then automate publishing new releases, as you can automate pushing from github to PiPy, and from PiPy to conda-forge.

For the pyproject.toml file, we could start just by adding the most minimal example, and then migrating metadata from setup.py with future releases:

[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

@freemansw1 freemansw1 linked a pull request Nov 1, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An ideal issue for new contributors to address workflow Improvements and updates to the repository and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pyproject.toml freemansw1/tobac
2 participants
@freemansw1 @w-k-jones