Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolation metric in tobac #70

Open
kelcyno opened this issue Feb 17, 2022 · 1 comment · May be fixed by #76
Open

Isolation metric in tobac #70

kelcyno opened this issue Feb 17, 2022 · 1 comment · May be fixed by #76
Labels
enhancement Addition of new features, or improved functionality of existing features

Comments

@kelcyno
Copy link
Collaborator

kelcyno commented Feb 17, 2022

Determining if a feature is isolated and how many neighbors it has - currently there is a pull request for this in the TINT theme, but not in tobac v1.0 theme. I suggest adding this in the segmentation_timestep function in the mask_segmentation file.

I've written a solution using dilation - where the feature shape is dilated by a user specified value and the number of neighbors falling within this dilated feature are counted and an isolation flag is raised (if no neighbors are found).

I can add this as a pull request but am not sure if it is better to add it in the v2.0 branch under the tobac theme or within the main branch.

@freemansw1 freemansw1 added the enhancement Addition of new features, or improved functionality of existing features label Feb 17, 2022
@freemansw1
Copy link
Member

I think this is a great idea. I think we would certainly be receptive to a PR for this. I think getting this into tobac 1.x would be extremely helpful as well given the timeline for a v2.0 release. I'd encourage you to do the PR into the dev branch, and we can then pull the changes into the v2.0-dev branch when it's finished (and we add in the 3D/PBC support that we're working on here at CSU).

@freemansw1 freemansw1 added this to the Version 1.5 milestone Mar 4, 2022
@freemansw1 freemansw1 linked a pull request May 15, 2022 that will close this issue
@freemansw1 freemansw1 removed this from the Version 1.5 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants